From ac60ece635318633eaa2418f9024ae405b581505 Mon Sep 17 00:00:00 2001 From: Benoit Daloze Date: Sat, 10 Oct 2020 13:40:07 +0200 Subject: [PATCH] Increase timeout on macOS * security/cve_2020_10663_spec.rb seems to often take > 30 seconds there, which is very surprising as it takes 5ms locally on Linux. https://github.com/ruby/spec/pull/795/checks?check_run_id=1230499776 --- .github/workflows/ci.yml | 20 ++++++++++++++------ 1 file changed, 14 insertions(+), 6 deletions(-) diff --git a/.github/workflows/ci.yml b/.github/workflows/ci.yml index 3de26b986d..b0aca3826e 100644 --- a/.github/workflows/ci.yml +++ b/.github/workflows/ci.yml @@ -23,16 +23,18 @@ jobs: - name: Clone MSpec run: git clone https://github.com/ruby/mspec.git ../mspec - - name: Run specs - if: matrix.os != 'windows' + - name: Run specs (Linux) + if: matrix.os == 'ubuntu' env: CHECK_LEAKS: true run: ../mspec/bin/mspec --timeout 30 - - name: Run C-API specs as C++ - if: matrix.os != 'windows' + + - name: Run specs (macOS) + if: matrix.os == 'macos' env: - SPEC_CAPI_CXX: true - run: ../mspec/bin/mspec :capi + CHECK_LEAKS: true + # Use a larger timeout on macOS since it seems to have less reliable performance + run: ../mspec/bin/mspec --timeout 60 - name: Run specs (Windows) if: matrix.os == 'windows' @@ -44,6 +46,12 @@ jobs: [Console]::InputEncoding = [System.Text.Encoding]::GetEncoding("IBM437") ../mspec/bin/mspec -j + - name: Run C-API specs as C++ + if: matrix.os != 'windows' + env: + SPEC_CAPI_CXX: true + run: ../mspec/bin/mspec :capi + rubocop: name: RuboCop runs-on: ubuntu-latest