Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding Reporting Categories to Items #5009

Open
1 task
cielf opened this issue Feb 11, 2025 · 2 comments · May be fixed by #5034
Open
1 task

Adding Reporting Categories to Items #5009

cielf opened this issue Feb 11, 2025 · 2 comments · May be fixed by #5034
Assignees

Comments

@cielf
Copy link
Collaborator

cielf commented Feb 11, 2025

Summary

Add reporting categories to items and populate from base items (both current items and new items)

Why?

Step 2 of simplification of reporting categories

Blocked by:

5008

Details

We need to:

  • create the same reporting categories from issue 5008 on the items,
  • ensure banks' new items' reporting categories are populated from the base items, and new items created from base items have their reporting categories populated
  • populate the current items reporting categories from their base items

Criteria for completion

  • migrations to achieve the above
@cielf cielf added the BLOCKED This issue is blocked by another label Feb 11, 2025
@coalest coalest removed the BLOCKED This issue is blocked by another label Feb 20, 2025
@coalest
Copy link
Collaborator

coalest commented Feb 21, 2025

@cielf I notice that the items table already has a category column, but at a glance it doesn't seem to be used. And at least in development after a fresh seed it is empty for all the items. is this column needed? I won't touch it for this PR, but maybe it could be removed.

@coalest coalest linked a pull request Feb 21, 2025 that will close this issue
@cielf
Copy link
Collaborator Author

cielf commented Feb 21, 2025

It still has content in prod data -- but not since 2019. It'll need some inspection, and maybe a migration to make sure they are linked to appropriate ItemCategories. Adding it to the queue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants