Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add roles column #5040

Open
wants to merge 3 commits into
base: main
Choose a base branch
from
Open

Conversation

napster235
Copy link
Contributor

@napster235 napster235 commented Feb 25, 2025

Resolves #5038

Description

Type of change

  • New feature (non-breaking change which adds functionality)

How Has This Been Tested?

Screenshots

Screenshot 2025-02-25 at 13 30 39

@cielf cielf self-requested a review February 25, 2025 14:38
Copy link
Collaborator

@cielf cielf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @napster235 -- Thanks for taking a swing at this!

I think we've missed something in communicating the need: Instead of the level of access and then either Organization or Partner as you currently have in the roles column, we need the level of access and the name of the specific organization or partner.

Hope that clears things up!

cielf
cielf previously requested changes Feb 25, 2025
Copy link
Collaborator

@cielf cielf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The above comment should have been a "request changes"

@napster235
Copy link
Contributor Author

@cielf Something like this?
Screenshot 2025-02-25 at 17 48 45

@cielf
Copy link
Collaborator

cielf commented Feb 25, 2025

@napster235 That looks more like it! (noting that those changes haven't been put up yet)

@napster235 napster235 requested a review from cielf February 26, 2025 10:43
@cielf cielf dismissed their stale review February 26, 2025 20:13

Addressed

@cielf
Copy link
Collaborator

cielf commented Feb 26, 2025

LGTM - over to @dorner for technical insight.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Admin user index -- remove organization column, but add roles column
2 participants