Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Management of roles on people who are superusers #4819

Open
3 tasks
cielf opened this issue Dec 1, 2024 · 5 comments · May be fixed by #5047
Open
3 tasks

Management of roles on people who are superusers #4819

cielf opened this issue Dec 1, 2024 · 5 comments · May be fixed by #5047
Assignees
@Benjamin-Couey
Labels
Difficulty—Intermediate

Comments

@cielf
Copy link
Collaborator

cielf commented Dec 1, 2024

Summary

If a super user has a role on an organization, neither the superuser nor the org admin can manage the role.

Why fix?

Might be symptomatic of something deeper. However, there is only one person with this situation now, and it's only on a test organization.

Details

We need to check into some data cleanup for this, but also the super user being able to assign other superusers

Criteria for completion

  • the user's role on a bank can be managed by the org_admin, no matter what other roles the user has (though they still can't delete themselves)
  • the superadmin can manage another superadmin's roles on a bank (I think we have another issue out there for superadmins managing the superadmin role (other than their own).
  • tests to support
@Benjamin-Couey
Copy link
Contributor

May I work on this one?

@cielf
Copy link
Collaborator Author

cielf commented Feb 12, 2025

Please do!

@github-actions github-actions bot removed the Help Wanted Groomed + open to all! label Feb 12, 2025
@Benjamin-Couey
Copy link
Contributor

@cielf Some small clarifications. This issue mentioned there being some other issue related to superadmins editing other superadmin’s roles, but I couldn’t find said issue. Do you know which issue it was?

Currently, in the list of org users, superadmin's are shown an edit button that takes them to the superadmin specific user management interface (as opposed to being shown the promote button that makes an org user into an org admin). Do we want to leave this as is, or have superadmins use the same interface as org admins?

@cielf
Copy link
Collaborator Author

cielf commented Feb 17, 2025

It's probably #4503

@cielf
Copy link
Collaborator Author

cielf commented Feb 17, 2025 •
edited
Loading

I'm not sure which way will end up being simpler in the longer run, tbh. Actually, I take that back... a quick skim through #4503 leads me to lean toward the superadmins would need a separate interface.

@cielf cielf mentioned this issue Feb 18, 2025
Open
2 tasks
@Benjamin-Couey Benjamin-Couey linked a pull request Feb 27, 2025 that will close this issue
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Benjamin-Couey Benjamin-Couey

Labels
Difficulty—Intermediate
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

4819 manage super user roles Benjamin-Couey/human-essentials
2 participants
@cielf @Benjamin-Couey