Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

no way to add prefix to file upload #3

Open
matchstick99 opened this issue Jul 30, 2023 · 0 comments
Open

no way to add prefix to file upload #3

matchstick99 opened this issue Jul 30, 2023 · 0 comments

Comments

@matchstick99
Copy link

matchstick99 commented Jul 30, 2023

can we add a prefix option to the dreambooth API so that I can upload my ckpt to a custom path on my bucket?
Specifically I want to be able to set the prefix parameter from the following function in rp_upload.py:

def upload_file_to_bucket(
        file_name: str, file_location: str,
        bucket_creds: Optional[dict] = None,
        bucket_name: Optional[str] = None,
        prefix: Optional[str] = None,
        extra_args: Optional[dict] = None
)

However dreambooth worker doesn't use this option at all

        # Upload the checkpoint file
        job_output['train']['checkpoint_url'] = upload_file_to_bucket(
            file_name=f"{job['id']}.ckpt",
            file_location=trained_ckpt,
            bucket_creds=s3_config,
            bucket_name=job['s3Config']['bucketName'],
        )
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant