3583 upgrade to ghc 9.2.7 (#3584)

Fixes #3583 

### Scope:

* Upgrades to lts-20.20 and ghc-9.2.7
* Removes all non-flake `nix` components
* Removes the "performance" measurement (which was not very useful any more)
* upgrades the Linux builds to ubuntu-22.04
* upgrades `hlint` to version `3.5` (minor adjustments required)
* integrates the formatting pass into the `Test` workflow 
   - for now it just prints a diff after formatting
   - later it should push a formatting commit and abort the workflow (exit with error) (next PR)

Author: jberthold

.github/workflows/release.yml

@@ -5,49 +5,13 @@ on:
       - master
 
 env:
-  ghc_version: "9.2.5"
-  stack_version: "2.9.1"
+  ghc_version: "9.2.7"
+  stack_version: "2.9.3"
 
 jobs:
-
-  check:
-    name: 'Check'
-    runs-on: ubuntu-20.04
-    steps:
-      - name: Check out code
-        uses: actions/checkout@v3
-        with:
-          submodules: recursive
-
-      - name: 'Install Nix'
-        uses: cachix/install-nix-action@v19
-        with:
-          install_url: https://releases.nixos.org/nix/nix-2.13.3/install
-          extra_nix_config: |
-            access-tokens = github.com=${{ secrets.GITHUB_TOKEN }}
-            substituters = http://cache.nixos.org https://hydra.iohk.io
-            trusted-public-keys = cache.nixos.org-1:6NCHdD59X431o0gWypbMrAURkbJ16ZPMQFGspcDShjY= hydra.iohk.io:f/Ea+s+dFdN+3Y/G+FDgSq+a5NEWhJGzdjvKNGv0/EQ=
-
-      - name: Install Cachix
-        uses: cachix/cachix-action@v12
-        with:
-          name: k-framework
-          skipPush: true
-
-      - name: Materialize
-        run: nix run .#update-cabal
-
-      - name: Check materialization
-        run: |
-          if [ -n "$(git status --porcelain 'nix/')" ]; then
-            echo 2>&1 "Error: found modified files"
-            git diff
-            exit 1
-          fi
-
   release:
     name: 'Release'
-    runs-on: ubuntu-20.04
+    runs-on: ubuntu-22.04
     steps:
       - name: Check out code
         uses: actions/checkout@v3
@@ -70,11 +34,11 @@ jobs:
           authToken: '${{ secrets.CACHIX_PUBLIC_TOKEN }}'
 
       - name: Build
-        run: nix-build -A kore -A project.kore.checks
+        run: nix-build -A project.x86_64_linux.kore -A project.x86_64_linux.kore.checks
 
   cache-cabal:
     name: 'Cache Cabal'
-    runs-on: ubuntu-20.04
+    runs-on: ubuntu-22.04
     steps:
       - name: Install prerequisites
         run: |
@@ -108,7 +72,7 @@ jobs:
 
   cache-stack:
     name: 'Cache Stack'
-    runs-on: ubuntu-20.04
+    runs-on: ubuntu-22.04
     steps:
       - name: Install prerequisites
         run: |
@@ -123,10 +87,10 @@ jobs:
         uses: actions/cache@v3
         with:
           path: ~/.stack
-          key: stack-2-${{ runner.os }}-${{ hashFiles('stack.yaml') }}-${{ hashFiles('stack.yaml.lock') }}
+          key: stack-2-${{ runner.os }}-ghc-${{ env.ghc_version }}-${{ hashFiles('stack.yaml') }}-${{ hashFiles('stack.yaml.lock') }}
           restore-keys: |
-            stack-2-${{ runner.os }}-${{ hashFiles('stack.yaml') }}
-            stack-2-${{ runner.os }}-
+            stack-2-${{ runner.os }}-ghc-${{ env.ghc_version }}-${{ hashFiles('stack.yaml') }}
+            stack-2-${{ runner.os }}-ghc-${{ env.ghc_version }}
 
       - uses: haskell/actions/setup@v2
         id: setup-haskell-stack
@@ -142,7 +106,7 @@ jobs:
 
   cache-stack-haddock:
     name: 'Cache Stack Haddock'
-    runs-on: ubuntu-20.04
+    runs-on: ubuntu-22.04
     steps:
       - name: Install prerequisites
         run: |
@@ -157,10 +121,10 @@ jobs:
         uses: actions/cache@v3
         with:
           path: ~/.stack
-          key: stack-haddock-2-${{ runner.os }}-${{ hashFiles('stack.yaml') }}-${{ hashFiles('stack.yaml.lock') }}
+          key: stack-haddock-2-${{ runner.os }}-ghc-${{ env.ghc_version }}-${{ hashFiles('stack.yaml') }}-${{ hashFiles('stack.yaml.lock') }}
           restore-keys: |
-            stack-haddock-2-${{ runner.os }}-${{ hashFiles('stack.yaml') }}
-            stack-haddock-2-${{ runner.os }}
+            stack-haddock-2-${{ runner.os }}-ghc-${{ env.ghc_version }}-${{ hashFiles('stack.yaml') }}
+            stack-haddock-2-${{ runner.os }}-ghc-${{ env.ghc_version }}
 
       - uses: haskell/actions/setup@v2
         id: setup-haskell-stack
@@ -178,7 +142,7 @@ jobs:
     name: 'Publish Release'
     runs-on: ubuntu-latest
     environment: production
-    needs: [check, release, cache-cabal, cache-stack, cache-stack-haddock]
+    needs: [release, cache-cabal, cache-stack, cache-stack-haddock]
     steps:
       - name: 'Update dependents'
         env:

.github/workflows/test.yml

@@ -6,22 +6,85 @@ concurrency:
   cancel-in-progress: true
 
 env:
-  ghc_version: "9.2.5"
-  stack_version: "2.9.1"
+  ghc_version: "9.2.7"
+  stack_version: "2.9.3"
 
 jobs:
+  formatting:
+    name: 'Auto-formatting'
+    runs-on: ubuntu-22.04
+    steps:
+      - id: config
+        run: |
+          ref="${{ github.event.pull_request.head.sha }}"
+          ref="${ref#refs/heads/}"
+          echo "ref=$ref" >> $GITHUB_OUTPUT
+
+          git config --global user.name github-actions
+          git config --global user.email [email protected]
+
+      - name: Check out code
+        uses: actions/checkout@v3
+        with:
+          ref: ${{ steps.config.outputs.ref }}
+          submodules: recursive
+          token: ${{ secrets.JENKINS_GITHUB_PAT }}
+
+      - name: 'Install Nix'
+        uses: cachix/install-nix-action@v19
+        with:
+          install_url: https://releases.nixos.org/nix/nix-2.13.3/install
+          extra_nix_config: |
+            access-tokens = github.com=${{ secrets.GITHUB_TOKEN }}
+            substituters = http://cache.nixos.org https://cache.iog.io
+            trusted-public-keys = cache.nixos.org-1:6NCHdD59X431o0gWypbMrAURkbJ16ZPMQFGspcDShjY= hydra.iohk.io:f/Ea+s+dFdN+3Y/G+FDgSq+a5NEWhJGzdjvKNGv0/EQ=
+
+      - name: 'Install Cachix'
+        uses: cachix/cachix-action@v12
+        with:
+          name: k-framework
+          authToken: '${{ secrets.CACHIX_PUBLIC_TOKEN }}'
+
+      - name: Format
+        run: |
+          nix run .#format
+
+      - name: Update branch
+        env:
+          GITHUB_EVENT_NAME: ${{ github.event_name }}
+        run: |
+          if [[ $GITHUB_EVENT_NAME == 'push' ]]; then
+            if git status -s -b | grep -q '^##.*(no branch)$'; then
+              echo 2>&1 "Error: Git is in detached HEAD state"
+              exit 1
+            fi
+          fi
+
+          if [ -n "$(git status --porcelain '*.hs')" ]; then
+            git add '*.hs'
+            git commit -m "Format with fourmolu"
+            git show --stat
+            # git push
+            echo "Reformatted code pushed, aborting this workflow" | tee -a $GITHUB_STEP_SUMMARY
+            # exit 1
+          fi
+
   nix-build:
     name: 'Nix / Unit Tests'
+    needs: formatting
     strategy:
       fail-fast: false
       matrix:
         include:
-          - runner: ubuntu-20.04
-            os: ubuntu-20.04
+          - runner: ubuntu-22.04
+            os: ubuntu-22.04
+            nix: x86_64-linux
           - runner: macos-12
             os: macos-12
+            nix: x86_64-darwin
           - runner: MacM1
             os: self-macos-12
+            nix: aarch64-darwin
     runs-on: ${{ matrix.runner }}
     steps:
       - name: Check out code
@@ -54,17 +117,17 @@ jobs:
           authToken: '${{ secrets.CACHIX_PUBLIC_TOKEN }}'
 
       - name: Build
-        run: nix-build -A kore
+        run: GC_DONT_GC=1 nix-build -A project.${{ matrix.nix }}.kore.components.exes
 
       - name: Check shell
-        run: nix develop --print-build-logs --command stack --version
+        run: nix develop --print-build-logs --command cabal --version
 
       - name: Run unit tests
-        run: nix-build -A project.kore.checks
+        run: GC_DONT_GC=1 nix-build -A project.${{ matrix.nix }}.kore.checks
 
   nix-integration:
     name: 'Nix / Integration'
-    runs-on: ubuntu-20.04
+    runs-on: ubuntu-22.04
     needs: nix-build
     steps:
       - name: Check out code
@@ -89,12 +152,21 @@ jobs:
           name: k-framework
           skipPush: true
 
+      - name: Test paths to Haskell backend binaries
+        run: |
+          nix develop github:runtimeverification/k/sam/nix-kore-integration-shell#kore-integration-tests \
+                --override-input haskell-backend . --update-input haskell-backend \
+                --command bash -c "echo kore-exec; which kore-exec; kore-exec --version; echo kore-parser; which kore-parser; kore-parser --version; echo kore-repl; which kore-repl; kore-repl --version; echo kore-match-disjunction; which kore-match-disjunction; kore-match-disjunction --version"
       - name: Run integration tests
-        run: nix-build test.nix
+        run: |
+          nix develop github:runtimeverification/k/sam/nix-kore-integration-shell#kore-integration-tests \
+                --override-input haskell-backend . --update-input haskell-backend \
+                --command bash -c "cd test && make -j2 --output-sync test"
 
   cabal:
     name: 'Cabal / Unit Tests'
-    runs-on: ubuntu-20.04
+    needs: formatting
+    runs-on: ubuntu-22.04
     steps:
       - name: Install prerequisites
         run: |
@@ -132,7 +204,8 @@ jobs:
 
   stack:
     name: 'Stack / Unit Tests'
-    runs-on: ubuntu-20.04
+    needs: formatting
+    runs-on: ubuntu-22.04
     steps:
       - name: Install prerequisites
         run: |
@@ -148,10 +221,10 @@ jobs:
         uses: actions/cache@v3
         with:
           path: ~/.stack
-          key: stack-2-${{ runner.os }}-${{ hashFiles('stack.yaml') }}-${{ hashFiles('stack.yaml.lock') }}
+          key: stack-2-${{ runner.os }}-ghc-${{ env.ghc_version }}-${{ hashFiles('stack.yaml') }}-${{ hashFiles('stack.yaml.lock') }}
           restore-keys: |
-            stack-2-${{ runner.os }}-${{ hashFiles('stack.yaml') }}
-            stack-2-${{ runner.os }}-
+            stack-2-${{ runner.os }}-ghc-${{ env.ghc_version }}-${{ hashFiles('stack.yaml') }}
+            stack-2-${{ runner.os }}-ghc-${{ env.ghc_version }}
 
       - uses: haskell/actions/setup@v2
         id: setup-haskell-stack
@@ -174,7 +247,8 @@ jobs:
 
   stack-haddock:
     name: 'Stack / Haddock check'
-    runs-on: ubuntu-20.04
+    needs: formatting
+    runs-on: ubuntu-22.04
     steps:
       - name: Install prerequisites
         run: |
@@ -190,10 +264,10 @@ jobs:
         uses: actions/cache@v3
         with:
           path: ~/.stack
-          key: stack-haddock-2-${{ runner.os }}-${{ hashFiles('stack.yaml') }}-${{ hashFiles('stack.yaml.lock') }}
+          key: stack-haddock-2-${{ runner.os }}-ghc-${{ env.ghc_version }}-${{ hashFiles('stack.yaml') }}-${{ hashFiles('stack.yaml.lock') }}
           restore-keys: |
-            stack-haddock-2-${{ runner.os }}-${{ hashFiles('stack.yaml') }}
-            stack-haddock-2-${{ runner.os }}
+            stack-haddock-2-${{ runner.os }}-ghc-${{ env.ghc_version }}-${{ hashFiles('stack.yaml') }}
+            stack-haddock-2-${{ runner.os }}-ghc-${{ env.ghc_version }}
 
       - uses: haskell/actions/setup@v2
         id: setup-haskell-stack
@@ -208,9 +282,10 @@ jobs:
           stack haddock --fast
   hlint:
     name: 'HLint'
-    runs-on: ubuntu-20.04
+    needs: formatting
+    runs-on: ubuntu-22.04
     env:
-      hlint_version: "3.4.1"
+      hlint_version: "3.5"
     steps:
       - uses: actions/checkout@v3
         with:
@@ -222,56 +297,4 @@ jobs:
         run: curl -sSL https://github.com/ndmitchell/hlint/releases/download/v${{ env.hlint_version }}/hlint-${{ env.hlint_version }}-x86_64-linux.tar.gz | tar xvz
 
       - name: Run hlint
-        run: hlint-${{ env.hlint_version }}/hlint kore -j
-
-  performance:
-    needs: [nix-build]
-    name: 'Performance'
-    runs-on: ubuntu-20.04
-    steps:
-      - name: Check out code
-        uses: actions/checkout@v3
-        with:
-          # Check out pull request HEAD instead of merge commit.
-          ref: ${{ github.event.pull_request.head.sha }}
-          submodules: recursive
-
-      - name: Install Nix
-        uses: cachix/install-nix-action@v19
-        with:
-          install_url: https://releases.nixos.org/nix/nix-2.13.3/install
-          extra_nix_config: |
-            access-tokens = github.com=${{ secrets.GITHUB_TOKEN }}
-            substituters = http://cache.nixos.org https://hydra.iohk.io
-            trusted-public-keys = cache.nixos.org-1:6NCHdD59X431o0gWypbMrAURkbJ16ZPMQFGspcDShjY= hydra.iohk.io:f/Ea+s+dFdN+3Y/G+FDgSq+a5NEWhJGzdjvKNGv0/EQ=
-
-      - name: Install Cachix
-        uses: cachix/cachix-action@v12
-        with:
-          name: k-framework
-          authToken: '${{ secrets.CACHIX_PUBLIC_TOKEN }}'
-          skipPush: true
-
-      - name: Collect performance statistics
-        env:
-          GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }}
-        run: |
-          ./scripts/test-statistics.sh ./. \
-            test/regression-evm \
-            test/regression-wasm \
-            > pull-request.json
-          git fetch origin
-          git worktree add kore-master master
-          ./scripts/test-statistics.sh ./kore-master \
-            test/regression-evm \
-            test/regression-wasm \
-            > master.json
-          ./scripts/join-statistics.sh master.json pull-request.json \
-            | ./scripts/format-statistics.sh \
-            > comment.md
-          if [[ $(sed -E -e '1,2d ; /.*\| (0|-?0.0[0-4][0-9]*) \| (0|-?0.0[0-4][0-9]*) \|$/d' comment.md | wc -l) -ne 0 ]]; then\
-            gh pr comment ${{ github.event.pull_request.number }} -F comment.md; \
-          else \
-            echo "Produced statistics are boring, just printing them right here:"; \
-            cat comment.md; \
-          fi
+        run: hlint-${{ env.hlint_version }}/hlint kore kore-rpc-types -j