Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Stabalization - roadmap to v1.0 #157

Open
tcharding opened this issue Nov 1, 2023 · 13 comments
Open

Stabalization - roadmap to v1.0 #157

tcharding opened this issue Nov 1, 2023 · 13 comments
Labels
1.0 Issues and PRs required or helping to stabilize the API

Comments

@tcharding
Copy link
Member

tcharding commented Nov 1, 2023

Tracking issue for what is needed for us to be able to stabalize the bech32 crate.

See also all issues marked with the 1.0 label: https://github.com/rust-bitcoin/rust-bech32/issues?q=is%3Aopen+is%3Aissue+label%3A1.0

@tcharding
Copy link
Member Author

tcharding commented Nov 1, 2023

Original discussion is in #60 but that issue is quite old and a bit stale. I've opened this one so that, if @apoelstra and @Kixunil are happy, we can close #60 to save others trawling through the stale stuff.

There is a problem though with this, not everyone can edit the issue like the ones on rust-bitcoin. I'm not a maintainer here and neither is @Kixunil - not sure how to project manage this crate.

I can just close this if its not an improvement over #60.

@tcharding
Copy link
Member Author

@clarkmoody or @apoelstra please add a 1.0 label same as rust-bitcoin.

name: 1.0
color: #78BE0C
description: Issues and PRs required or helping to stabilize the API

@apoelstra
Copy link
Member

Done.

@tcharding
Copy link
Member Author

tcharding commented Nov 6, 2023

Oh I can't add labels to issues, even ones I wrote myself.

@apoelstra
Copy link
Member

:/. Do you remember offhand if there's a non-maintainer github role that would let you do that?

@apoelstra
Copy link
Member

@clarkmoody can we make @tcharding a "Triage" member here?

I will do the same on rust-secp if you need, @tcharding .

@tcharding
Copy link
Member Author

I will do the same on rust-secp if you need, @tcharding .

Yes please.

@clarkmoody
Copy link
Member

@clarkmoody can we make @tcharding a "Triage" member here?

Done! 😄

@tcharding
Copy link
Member Author

Thanks!

@tcharding tcharding added the 1.0 Issues and PRs required or helping to stabilize the API label Feb 20, 2024
@clarkmoody
Copy link
Member

I am good with stabilization as soon as is reasonable.

@tcharding
Copy link
Member Author

Great! Now that error correction is done I believe this is the closest crate we have (in the rust-bitcoin stack) to stabalization. We have removed it from the public API of rust-bitcoin though, so its not totally required to stabalize it. I personally still think it would be good to do, and good for us as a team to get something released as 1.0

@apoelstra
Copy link
Member

Now that error correction is done

Unfortunately it's "done" except for the user-facing API, which turn out to be the hardest part :) (though I don't think so).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
1.0 Issues and PRs required or helping to stabilize the API
Projects
None yet
Development

No branches or pull requests

3 participants