-
Notifications
You must be signed in to change notification settings - Fork 492
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
is_flag_supported
returns false negatives
#1423
Comments
Hmmm is looks like the flag is removed. |
Wow I'm glad this was one of the top issues, I've come across a false negative here: https://github.com/brson/wasm-opt-rs/blob/8854bd8a58d7393c7bacd950884aea521ce8e19f/components/wasm-opt-sys/build.rs#L8 |
I have opened PR #1424 but I don't have time to fix the CI errors, if anyone is willing to pickup and fix it, I'm happy to merge it |
Seems like #892 is back. I once submitted a patch in #839 and that worked for me at the time, but after an update to
cc
v1.2.15 I'm having the same issues again. I'm onwasm32-unknown-unknown
and using.flag_if_supported("-Wno-unused-parameter")
doesn't add the flag even though it's supported.The text was updated successfully, but these errors were encountered: