Define byte #1772
Merged
Define byte #1772
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is split off from rust-lang#1664 which defines what a "byte" is. Closes rust-lang#1673
rustbot
added
the
S-waiting-on-review
RalfJung
reviewed
Apr 1, 2025
|
This seems fairly non-controversial, given in particular that we do not say what exactly a "provenance" looks like. However, it does seem to me like we should involve @rust-lang/lang as well, given that this will make stable promises. Though I cannot entirely articulate what we are actually committing to -- I guess it is the fact that uninitialized memory is "real" as far as Rust is concerned, and distinct from all 256 regular initialized states of a byte. But that's long-established consensus, isn't it? |
RalfJung
reviewed
Apr 1, 2025
We didn't feel like this was well-defined enough to go into right now, and didn't seem necessary to include right now.
traviscross
approved these changes
Apr 1, 2025
|
Yes, I think it is. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is split off from #1664 which defines what a "byte" is.
Closes #1673
cc @rust-lang/opsem, would you be willing to review?