Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cannot enqueue more than one build for a PR at a time #1396

Open
rylev opened this issue Aug 12, 2022 · 1 comment
Open

Cannot enqueue more than one build for a PR at a time #1396

rylev opened this issue Aug 12, 2022 · 1 comment

Comments

@rylev
Copy link
Member

rylev commented Aug 12, 2022

When testing a regressed rollup, we may want to enqueue more than one build at a time. However, this is not possible because of a constraint on the database (found here). It's not clear to me if this constraint is actually needed or not. I can see how it might prevent certain bugs where we overly commit try builds, but in this case it is too restrictive. Can we remove this constraint?

@Mark-Simulacrum
Copy link
Member

I believe the goal with the constraint was to deduplicate queueing, to make rust-timer queue essentially idempotent. I don't think it needs to be the case when directly specifying a SHA to build via rust-timer build, though.

I'd need to put some thought into quite how we manage that from a DB perspective, but it's also plausible we could just drop the constraint entirely. I think it was mostly intended to prevent needing to decide which row to attach to when we have a build ready to start...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants