Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve rendering of history graphs #1938

Closed
Kobzol opened this issue Jul 4, 2024 · 3 comments · Fixed by #1988
Closed

Improve rendering of history graphs #1938

Kobzol opened this issue Jul 4, 2024 · 3 comments · Fixed by #1988

Comments

@Kobzol
Copy link
Contributor

Kobzol commented Jul 4, 2024

When you open the graph history page with a single graph selected (common when coming from the compage page), it would be nice to show the graph over the full page, rather than just in a small box.

Also, some improvements could be made to improve the readability of the graph when it contains a wide range of values (#1936 (comment)).

@s7tya
Copy link
Contributor

s7tya commented Jul 11, 2024

is this mean expanding the width of graph to the screen width?
CleanShot 2024-07-11 at 16 28 31@2x

@Kobzol
Copy link
Contributor Author

Kobzol commented Jul 11, 2024

Yes, I think that would be nice. At the very least if there is really only a single graph selected, it should expand. Does not necessarily be to the whole screen (not sure if that looks good?), but it should be larger.

@s7tya
Copy link
Contributor

s7tya commented Jul 11, 2024

I see. it might be nice to check if both benchmark & profile option are set to determine single graph is selected.
→ Because of previous change, we should check the length of API resp to determine whether single graph is selected or not.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants