Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

strange behavior for duplicate imports with imports_granularity="Module" #6243

Open
xxchan opened this issue Jul 17, 2024 · 1 comment
Open
Labels
bug Panic, non-idempotency, invalid code, etc. only-with-option requires a non-default option value to reproduce

Comments

@xxchan
Copy link
Contributor

xxchan commented Jul 17, 2024

e.g.,

use risingwave_batch::executor::{BoxedExecutor, JoinType};
use risingwave_batch::executor::{BoxedExecutor, JoinType};

After first fmt

use risingwave_batch::executor::{BoxedExecutor, BoxedExecutor, JoinType, JoinType};

After second fmt

use risingwave_batch::executor::{BoxedExecutor, JoinType, JoinType};

The behavior I want is that it can remove duplicates, like imports_granularity="Crate"

@ytmimi ytmimi added bug Panic, non-idempotency, invalid code, etc. only-with-option requires a non-default option value to reproduce labels Jul 17, 2024
@ytmimi
Copy link
Contributor

ytmimi commented Jul 17, 2024

Confirming I can reproduce this when building from source using rustfmt 1.7.1-nightly (7cdb426 2024-07-15). Linking the tracking issue for imports_granularity (#4991)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Panic, non-idempotency, invalid code, etc. only-with-option requires a non-default option value to reproduce
Projects
None yet
Development

No branches or pull requests

2 participants