Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add some tests #16

Open
ssoroka opened this issue Dec 11, 2018 · 1 comment
Open

add some tests #16

ssoroka opened this issue Dec 11, 2018 · 1 comment

Comments

@ssoroka
Copy link

ssoroka commented Dec 11, 2018

Would be great to have some tests in place so there's some confidence that this stays working. Would also likely improve the code structure.

@rwynn
Copy link
Owner

rwynn commented Dec 11, 2018

@ssoroka thanks for trying gtm. I would love to add tests to this project but currently don't have the spare time to do so. If I do get some time I will add something probably based on the docker tests at

https://github.com/rwynn/monstache/tree/master/docker/test

which indirectly tests gtm by testing monstache - realtime sync between MongoDB and Elasticsearch

  • via docker-compose for ease of replication.

Would probably start with that as a base, remove the Elasticsearch stuff, increase the version coverage of MongoDB, and write a test driver like the one here...

https://github.com/rwynn/monstache/blob/master/monstache_test.go

If you have time to do something like this I would appreciate it as a PR. If not, I will try to get to it when possible.

You may have been referring more to unit tests instead of functional tests. If so I agree those would be great also.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants