Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

build/pkgs/sagetex: missing dependency on $(PYTHON_TOOLCHAIN) ? #38657

Closed
orlitzky opened this issue Sep 13, 2024 · 4 comments · Fixed by #38752
Closed

build/pkgs/sagetex: missing dependency on $(PYTHON_TOOLCHAIN) ? #38657

orlitzky opened this issue Sep 13, 2024 · 4 comments · Fixed by #38752

Comments

@orlitzky
Copy link
Contributor

It needs python_build, which is part of PYTHON_TOOLCHAIN, though maybe there's a better answer:

[sagetex-3.6.1] No stamp file for package 'sagetex' in /home/mjo/src/sage.git/local/var/lib/sage/venv-python3.12/var/lib/sage/installed
[sagetex-3.6.1] No spkg-legacy-uninstall script; nothing to do
[sagetex-3.6.1] [spkg-install] Installing sagetex-3.6.1
[sagetex-3.6.1] [spkg-install] /home/mjo/src/sage.git/local/var/lib/sage/venv-python3.12/bin/python3: No module named build
[sagetex-3.6.1] [spkg-install] Warning: building with "python3 -m build --wheel --outdir=dist   ." failed.
[sagetex-3.6.1] [spkg-install] Retrying with "python3 -m build --wheel --outdir=dist --no-isolation --skip-dependency-check  .".
[sagetex-3.6.1] [spkg-install] /home/mjo/src/sage.git/local/var/lib/sage/venv-python3.12/bin/python3: No module named build
[sagetex-3.6.1] [spkg-install] ********************************************************************************
[sagetex-3.6.1] [spkg-install] Error building a wheel for sagetex-3.6.1
[sagetex-3.6.1] [spkg-install] ********************************************************************************
@orlitzky orlitzky mentioned this issue Sep 13, 2024
Merged
@orlitzky
Copy link
Contributor Author

@mkoeppe I could certainly fix this but I see a commit by you changing $(PYTHON_TOOLCHAIN) to pip?

@mkoeppe
Copy link
Contributor

mkoeppe commented Sep 21, 2024 via email

@mkoeppe
Copy link
Contributor

mkoeppe commented Sep 26, 2024

... but of course sagetex is not a wheel package. So adding $(PYTHON_TOOLCHAIN) is the correct fix. PR please?

vbraun pushed a commit to vbraun/sage that referenced this issue Sep 27, 2024
sagemathgh-38658: configure.ac: add --disable-sagetex option
31596e3 
    
SageTeX is a standard package, but it isn't used anywhere else in the
sage library or even in the sage distribution. If you know you don't
need it, the new `--disable-sagetex` option lets you avoid downloading
and installing it.

(inspired by sagemath#38657, but I should
have done this a long time ago)
    
URL: sagemath#38658
Reported by: Michael Orlitzky
Reviewer(s): Dima Pasechnik
vbraun pushed a commit to vbraun/sage that referenced this issue Sep 28, 2024
sagemathgh-38658: configure.ac: add --disable-sagetex option
c77a5b0 
    
SageTeX is a standard package, but it isn't used anywhere else in the
sage library or even in the sage distribution. If you know you don't
need it, the new `--disable-sagetex` option lets you avoid downloading
and installing it.

(inspired by sagemath#38657, but I should
have done this a long time ago)
    
URL: sagemath#38658
Reported by: Michael Orlitzky
Reviewer(s): Dima Pasechnik
orlitzky added a commit to orlitzky/sage that referenced this issue Oct 2, 2024
@orlitzky
build/pkgs/sagetex/dependencies: add $(PYTHON_TOOLCHAIN)
02ee063 
Our sagetex package needs python_build, included as part of
$(PYTHON_TOOLCHAIN), to build.

Closes: sagemath#38657
@orlitzky orlitzky mentioned this issue Oct 2, 2024
Merged
vbraun pushed a commit to vbraun/sage that referenced this issue Oct 5, 2024
sagemathgh-38752: build/pkgs/sagetex/dependencies: add $(PYTHON_TOOLC…
b188ad0 
…HAIN)

    
Our sagetex package needs python_build, included as part of
`$(PYTHON_TOOLCHAIN)`, to build.

Closes: sagemath#38657
    
URL: sagemath#38752
Reported by: Michael Orlitzky
Reviewer(s): Matthias Köppe
@orlitzky
Copy link
Contributor Author

orlitzky commented Oct 7, 2024

It looks like #38752 is going in. Closing this now so I don't forget.

@orlitzky orlitzky closed this as completed Oct 7, 2024
vbraun pushed a commit to vbraun/sage that referenced this issue Oct 9, 2024
sagemathgh-38752: build/pkgs/sagetex/dependencies: add $(PYTHON_TOOLC…
661ee69 
…HAIN)

    
Our sagetex package needs python_build, included as part of
`$(PYTHON_TOOLCHAIN)`, to build.

Closes: sagemath#38657
    
URL: sagemath#38752
Reported by: Michael Orlitzky
Reviewer(s): Matthias Köppe
vbraun pushed a commit to vbraun/sage that referenced this issue Oct 11, 2024
sagemathgh-38752: build/pkgs/sagetex/dependencies: add $(PYTHON_TOOLC…
fe666a2 
…HAIN)

    
Our sagetex package needs python_build, included as part of
`$(PYTHON_TOOLCHAIN)`, to build.

Closes: sagemath#38657
    
URL: sagemath#38752
Reported by: Michael Orlitzky
Reviewer(s): Matthias Köppe
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

build/pkgs/sagetex/dependencies: add $(PYTHON_TOOLCHAIN) orlitzky/sage
2 participants
@orlitzky @mkoeppe