You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
The vertex of Gim should not be sorted by default.
Actual Behavior
The vertex of Gim are sorted by default.
Additional Information
The sorting happens in src/sage/graphs/base/static_sparse_backend.pyx (line 515).
It should not be the default behaviour as it breaks most complexity claims around graphs.
I try removing the sort in PR #38427 but I gave up as it breaks too many doctests in very different parts of SageMath (Lie algebra, elliptic curve, categories, poset, ...).
Even the code of StaticSparseBackend (the class implementing immutable graphs) rely on the fact that the vertices are sorted as illustrated by the fact that the two methods iterator_edges and iterator_unsorted_edges are the same.
Steps To Reproduce
Expected Behavior
The vertex of
Gim
should not be sorted by default.Actual Behavior
The vertex of
Gim
are sorted by default.Additional Information
The sorting happens in
src/sage/graphs/base/static_sparse_backend.pyx
(line 515).It should not be the default behaviour as it breaks most complexity claims around graphs.
I try removing the sort in PR #38427 but I gave up as it breaks too many doctests in very different parts of SageMath (Lie algebra, elliptic curve, categories, poset, ...).
Even the code of StaticSparseBackend (the class implementing immutable graphs) rely on the fact that the vertices are sorted as illustrated by the fact that the two methods
iterator_edges
anditerator_unsorted_edges
are the same.This issue may be linked to the meta issue #35902
Environment
Checklist
The text was updated successfully, but these errors were encountered: