Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve counting of local solutions for QuadraticForm at p=2 #38680

Open
wants to merge 1 commit into
base: develop
Choose a base branch
from
Open

Improve counting of local solutions for QuadraticForm at p=2 #38680

wants to merge 1 commit into from
+102 −22

Conversation

WvanWoerden
Copy link

Fixes #38679.

Introduces new method CountAllLocalGoodTypesNormalForm(Q, p, k, m, zvec, nzvec) to compute the number of local solutions of 'good type' for Q[v] = m mod p^k when Q is in local normal form at p.
This replaces the use of the slow brute-force function CountAllLocalTypesNaive indirectly used in local_good_density_congruence_even for (p,k)=(2,3) .

📝 Checklist

  • The title is concise and informative.
  • The description explains in detail what this PR is about.
  • I have linked a relevant issue or discussion.
  • I have created tests covering the changes.
  • I have updated the documentation and checked the documentation preview.

⌛ Dependencies

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
c: quadratic forms p: major / 3 s: needs review t: enhancement
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Improve counting of local solutions for QuadraticForm at p=2
2 participants
@WvanWoerden @yyyyx4