Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Model saving #18

Open
adavoli91 opened this issue May 2, 2020 · 5 comments
Open

Model saving #18

adavoli91 opened this issue May 2, 2020 · 5 comments

Comments

@adavoli91
Copy link

Hi,
is it possible to save a model, e.g. with pickle?
Thanks

@mgckind
Copy link
Collaborator

mgckind commented May 4, 2020

Hi @adavoli91,
On the python version of eif can be pickled, for the cython and faster version we need to implement that. Thanks for letting us know, we'll try to add that in the future.

@adavoli91
Copy link
Author

Thank you for the reply.

I managed to pickle eif_old, but I noticed that the output file is very large (~100MB for a dataset with ~500 rows and ~60 columns); the same dataset, processed with IF from sklearn, gives a pickle file of less than 1MB. Is that expected, or can it be handled?

Thans

@mgckind
Copy link
Collaborator

mgckind commented May 4, 2020

Thanks,

I think that;s expected since the eif_old is purely python while sklearn is C-based. The ideal scenario would be to add pickle to the cython class which requires some little development.

@lpryszcz
Copy link

Hi @mgckind , I back this feature request. I found eIF super useful and the only feature I'm lacking currently is model saving. Have you had any opportunity to work on that?

@lpryszcz
Copy link

I've rewritten Python version as eif_new.py. This version has performance matching C++ (~40x faster than eif_old.py) and allow model saving with model files 10x smaller than eif_old.py #24

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants