-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Question: is it possible to run OpInf-FOM-OpInf coupling? #69
Comments
@ikalash I'll diagnose and get this fixed. |
Thank you @eparish1 ! It might be that just a throw needs to be removed. I would think you can do OpInf-FOM-OpInf if the requirement is that an OpInf model be coupled always to a FOM, not another OpInf. |
Yes, you might just be able to drop the throw. I remember not really liking this bit of the code though, so I'll take a look and see if I can come up with a better solution. |
@eparish1 : sounds good. I haven't looked at the relevant parts of the code yet, so dropping the throw may not be sufficient. |
The issue is just because of the throws, and it can be mitigated by commenting these out. However, I think it raises the bigger issue of how we want to handle this. The "best" way is to probably add another field to the OpInf ROM corresponding to its FOM model type. The only negative thing about this is its another field the user needs to put in. The easiest thing is to just remove the throws for only allowing Schwarz if the models are the same type. It looks like the code just quits if they aren't the same type anyway. I'm happy to go with whatever path. Any preferences? |
I removed all that code, see sandialabs/Norma.jl@967824e76e334357f72d25c745905672537878f0 for reasons. |
Thanks for making the change @lxmota . I will try again the OpInf-FOM-OpInf coupling soon to verify that it works now. |
This is a question for @eparish1 : is there a plan to make it possible to run an OpInf-FOM-OpInf coupling when a 3 subdomain DD is employed? When I try this for the laser weld problem, I get the following error:
The text was updated successfully, but these errors were encountered: