Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Automate release tarball creation #103

Open
ronawho opened this issue Dec 15, 2021 · 3 comments
Open

Automate release tarball creation #103

ronawho opened this issue Dec 15, 2021 · 3 comments
Assignees

Comments

@ronawho
Copy link
Contributor

ronawho commented Dec 15, 2021

There have been generated files included in the last several release tarballs. I believe this is due to manually creating the tarball from a directory where autogen/configure has been run.

I have caught this a few times while upgrading versions, though I missed some when upgrading to the 1.16 release in chapel-lang/chapel#17229. In 1.16 there were a lot of files in an installed directory. There were different files for 1.17 but I believe we caught all those.

Offline @janciesko and I had discussed automating the process to avoid issues like this. There are probably github actions that would let you automate creating your tarball. With a quick search https://github.com/marketplace/actions/create-release seems promising, but there are probably others.

(We discussed this offline a while back, but this recently bit us in Homebrew/homebrew-core#91257 (comment) so I wanted to create an issue before I forgot.)

@olivier-snl
Copy link
Collaborator

Thanks @ronawho . This is an important issue to address.

@janciesko janciesko self-assigned this Dec 18, 2021
@janciesko janciesko added 3.8 1.18 and removed 3.8 labels Sep 8, 2022
@janciesko
Copy link
Collaborator

janciesko commented Sep 19, 2022

This script [1] runs autotools, generates the configure script and replaces linked files by actual files required during ./configure.
The next step would be to trigger this script on a GitHub Actions event when a tag is pushed.

[1] #115

@ronawho
Copy link
Contributor Author

ronawho commented Sep 7, 2023

Just noting the package.sh script seems to be producing pretty clean tarballs the last 2 releases, so I'd have no problem closing this. Your call if it's worth the additional work of figuring out a github action.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants