-
Notifications
You must be signed in to change notification settings - Fork 14
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: close overlay stack with Escape key [WIP] #3385
Open
DavideMininni-Fincons
wants to merge
8
commits into
main
Choose a base branch
from
fix/esc-keydown-overlays
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The proposed implementation revolves around a new base class which maintains a registry of overlays;
it can be improved in a couple of points.
isOpen=true
). The usage of theWeakRef
API could (in theory) solve this issue; however I tried to force the garbage collector with the Chrome Devtools console and nothing happened.ESC
with no visible overlays will call theclose
method on old instances. Could it lead to issues?cleanStack
method will work if the overlays are not reused (e.g element with the same id in different pages) and will not work for overlays in the ShadowDOMA proposal discussed with @TomMenga could be to not maintain a registry and to simply use
event.preventDefault
combined with the check onevent.defaultPrevented
in all the keydown function onESC
hit.