Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Some notes on responsive images #272

Open
wrobelda opened this issue May 27, 2024 · 1 comment
Open

Some notes on responsive images #272

wrobelda opened this issue May 27, 2024 · 1 comment

Comments

@wrobelda
Copy link

wrobelda commented May 27, 2024

Hi there,

I used your responsive image code to add similar functionality to WonderMod theme in this PR.

I did make a few changes, though, namely:
— I added an AutoOrient filter to prevent Hugo from losing the EXIF rotation information upon rendering the images (https://gohugo.io/functions/images/autoorient/)
— ported back the figcaption section from the original figure Hugo shortcode, such that your image partial can be used to generate img in figure shortcode as well, although my understanding is you don't offer that.

I thought you'd find that noteworthy.

@schnerring
Copy link
Owner

I'll leave this issue open until I find the time to incorporate this into the theme.

Thanks for the feedback!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants