Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reflect Twitter -> X #349

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Reflect Twitter -> X #349

wants to merge 1 commit into from

Conversation

deining
Copy link

@deining deining commented Feb 18, 2025

This PR resolves #276.

@schnerring
Copy link
Owner

Thanks! I think we need to also bump the minimum Hugo version to 0.141.0 inside config/_default/module.toml.

From the 0.141.0 release notes:

tpl/tplimpl: Deprecate twitter shortcode in favor of x shortcode gohugoio/hugo@1191467 @jmooring gohugoio/hugo#13214

@deining
Copy link
Author

deining commented Feb 21, 2025

Thanks!

You are welcome!

I think we need to also bump the minimum Hugo version to 0.141.0

Hmm, not sure about this. This PR uses the new x shortcode only onde in content/blog/rich-content.md. When using the theme as module, we do not mount the content folder, so I wouldn't expect that the use of the shortcode causes hugo to throw an error. I haven't tested this, though.
Please note my other PR #350. This PR requires minimum Hugo version of 0.141.0, so if you decide to merge this PR, we can stop discussing here 😄.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Rebranding Twitter to X
2 participants