Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Location of sub-commands #3

Open
LecrisUT opened this issue Oct 19, 2023 · 2 comments
Open

Location of sub-commands #3

LecrisUT opened this issue Oct 19, 2023 · 2 comments

Comments

@LecrisUT
Copy link
Collaborator

What are your opinions on where the sub-commands should reside? In this repo or in scikit-build-core[cli]?

  • if we have it in this repo the dependencies in skbuild-core are minimized, but it is less flexible about changing the upstream api, like how we call cmake.configure, and vice-versa if we move the subcommands
  • in both cases there should be some integration testing that we can call from one-another
  • how will we handle the version dependencies? We'll keep backwards compatibility on this cli or move lower-upper bound dependency?
@henryiii
Copy link
Contributor

I think inside this repo. That keeps scikit-build-core clean and with minimal dependencies. Since we control both packages, we can pin somewhat (>=0.6,<.7) - we can release a new version once we know 0.7 won't change the API, etc. Though the basics should be pretty stable, and scikit-build-core is supposed to be usable as a plugin.

@henryiii
Copy link
Contributor

FYI, we are having our monthly scikit-build community meeting tomorrow, 12 EDT if you'd like to join. https://meet.google.com/dvx-jkai-xhq

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants