Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: relay fee in msats #169

Closed
wants to merge 1 commit into from
Closed

fix: relay fee in msats #169

wants to merge 1 commit into from

Conversation

thesimplekid
Copy link
Contributor

It seems clients expect for the fee to me in msats in the relay info response even though there is a unit field.

fix: #167

@thesimplekid thesimplekid mentioned this pull request Oct 31, 2023
Open
@mroxso
Copy link

mroxso commented Nov 1, 2023

thank you! i will test this later

mroxso
mroxso approved these changes Nov 1, 2023
View reviewed changes
Copy link

@mroxso mroxso left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

tested and seems to work like expected 💯

@scsibug
Copy link
Owner

scsibug commented Nov 3, 2023

Thanks for the fix and testing! Merged.

@scsibug scsibug closed this Nov 3, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mroxso mroxso mroxso approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Wrong payment information in relay details
3 participants
@thesimplekid @mroxso @scsibug