Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support u32 face index #263

Open
virtualritz opened this issue Dec 26, 2020 · 8 comments
Open

Support u32 face index #263

virtualritz opened this issue Dec 26, 2020 · 8 comments

Comments

@virtualritz
Copy link

virtualritz commented Dec 26, 2020

Mesh::faces is currently Vec<Point3<u16>>.

It would be great to make this u32 to allow meshes with >64k points.
Either always or as a variant, as e.g. in bevy's IndexFormat.

@brightly-salty
Copy link

I'd be willing to attempt to implement this and submit a PR if it would be accepted.

@sebcrozet
Copy link
Owner

Hi! The problem with meshes with u32 indices is that they are not compatible with WebGL 1.0. So we can't only allow u32. Using a variant would be an accepted solution, yes.

@virtualritz
Copy link
Author

Is that really a problem? I mean do you know what % of your crate's users rely on WebGl 1.0 compatibility?

@sebcrozet
Copy link
Owner

Is that really a problem? I mean do you know what % of your crate's users rely on WebGl 1.0 compatibility?

I don't know the percentage but I am one of these users. WebGl 2.0 isn't well supported on Safari without enabling some experimental features: https://caniuse.com/webgl2

@virtualritz
Copy link
Author

Any update on this?

@virtualritz
Copy link
Author

WebGL 2 is now supported in Safari, it seems.

@LeandroMarceddu
Copy link

Bump this, I cannot load certain large meshes due to this. Any updates/workarounds?

@virtualritz
Copy link
Author

It's been 11 months now that Safari 15 with WebGl 2 support was released. Looking at caniuse.com it seems only fringe browsers do not support this version.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

5 participants