Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Couple of Modification Requests #203

Open
j8h9 opened this issue Sep 14, 2014 · 4 comments
Open

Couple of Modification Requests #203

j8h9 opened this issue Sep 14, 2014 · 4 comments

Comments

@j8h9
Copy link

j8h9 commented Sep 14, 2014

How can I change code so

  1. Ability to modify datestamp so I can load old articles
  2. Ability to share private articles with specific users or groups
    5, Display timestamps on daily page
@e2jk
Copy link

e2jk commented Sep 21, 2014

Regarding question 1:
The function that saves a url (search for "save_edit" in index.php) takes it from the POST variable lf_linkdate
Searching the code for that variable, Line 14 in tpl/editlink.html has a hidden field where it is set

<input type="hidden" name="lf_linkdate" value="{$link.linkdate}">

When editing a link on my own shaarli, I see for example the following value in that field: 20140801_232153

I guess that if you removed the type="hidden" from line 14 previously mentioned you could enter a date_time in this format.

Regarding point 2: that seems to me to be out of scope for a system that is based on the KISS [Keep It Simple, Stupid] principles. The way Shaarli has been built, you either have public, or private links. There is no "visitor's account" for which you would be able to indicate if a link is visible or not. I would not expect such a feature to be implemented in Shaarli's main code branch.

I'm not sure if you expected to have points 3 and 4, but point 5: I guess you could add a div in /tpl/daily.html that would output {$value.linkdate}. I haven't tested that though.

@nodiscc
Copy link

nodiscc commented Oct 15, 2014

I have added doc on how to manipulate timestamps at https://github.com/shaarli/Shaarli/wiki#changing-timestamp-for-a-link (thanks @e2jk)

I will add timestamps in the daily page for the fork at https://github.com/shaarli/Shaarli/. These timestamps will respect the HIDE_TIMESTAMPS setting.

@j8h9 can you close this issue?

@e2jk
Copy link

e2jk commented Oct 20, 2014

@j8h9 please close this issue.

+Emilien

@nodiscc
Copy link

nodiscc commented Oct 21, 2014

Timestamps issue recorded at shaarli#26

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants