Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Module imports need to be removed for Objective-C++ compatibility (React Native 0.68+) #1036

Open
shamilovtim opened this issue Jun 14, 2022 · 1 comment

Comments

@shamilovtim
Copy link

shamilovtim commented Jun 14, 2022

The module imports are unnecessary and they create complications for Objective-C++:
Screen Shot 2022-06-14 at 7 01 00 PM

If users add the flags for Objective-C++ modules it will break other dependencies in their projects. Could you please remove the module imports and use the header system like the rest of these files are already using?

Related:
firebase/FirebaseUI-iOS#875
facebook/react-native#33692
invertase/react-native-firebase#6223

@shamilovtim shamilovtim changed the title Module imports need to be removed from Objective-C Module imports need to be removed for Objective-C++ compatibility (React Native 0.68+) Jun 14, 2022
@WYZEYaolongZhu
Copy link

image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants