@semaphore-protocol/data uses utility functions that can be replaced by @zk-kit/utils
#773
Assignees
Labels
good first issue
Good for newcomers
refactoring ♻️
A code change that neither fixes a bug nor adds a feature
Milestone
Comments
cedoor
added
refactoring ♻️
|
Can you assign this to me please? |
|
Hey @jancris100 sure. I just assigned you this issue. Please, let us know if you have questions. |
|
Hey! I'm Hannah, a developer studying with the PSE Core program :) If this isn't in progress already I would be happy to take it on. @vplasencia @jancris100 |
|
Hey @hannahredler, there's already a PR for this issue. Let's try to ping the author and ask them first. @jancris100 there are some issues to solve in your PR: #782. Let us know if you've time to work on it. Otherwise no problem, just a double-check before re-assigning the issue. |
|
This issue i already finish it a long time ago |
|
@jancris100 great! Could you reply to my comments there? Some conflicts also need to be resolved. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Description
@semaphore-protocol/datausescheckParametersto check if the parameter types are the correct ones. Since there's already a@zk-kit/utilsdependency, it could use the zk-kit utilityerror-handlersfunctions directly, and avoid duplicating code.The text was updated successfully, but these errors were encountered: