Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update cli monorepo ethers and subgraph web app UI #841

Open
wants to merge 15 commits into
base: main
Choose a base branch
from
Open

Update cli monorepo ethers and subgraph web app UI #841

wants to merge 15 commits into from

Conversation

yagopajarino
Copy link

@yagopajarino yagopajarino commented Jul 28, 2024 •
edited by cedoor
Loading

Description

Update cli template ethers and subgraph web app UI using boilerplate code from https://github.com/semaphore-protocol/boilerplate/tree/main/apps/web-app

Related Issue(s)

Closes #836

Checklist

  • My code follows the style guidelines of this project
  • I have performed a self-review of my code
  • I have commented my code, particularly in hard-to-understand areas
  • My changes generate no new warnings
  • I have run yarn format and yarn lint without getting any errors
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes

@yagopajarino yagopajarino requested a review from a team as a code owner July 28, 2024 22:53
@vplasencia
Copy link
Member

Hey @yagopajarino!

If you run yarn in the project root directory, do you see that the yarn.lock file was modified? If so, can you also push these changes?

@yagopajarino
Copy link
Author

Pushed the new yarn.lock :)

@cedoor
Copy link
Member

cedoor commented Aug 7, 2024

Hi @yagopajarino, could you solve the conflicts?

@yagopajarino
Copy link
Author

Hi @cedoor! I just synced the fork and solved the conflicts, let me know if there are any additional changes needed

@cedoor
Copy link
Member

cedoor commented Aug 13, 2024

@yagopajarino looks like there're still conflicts.

@yagopajarino
Copy link
Author

Hi @cedoor! Fixed the conflicts

vplasencia
vplasencia requested changes Aug 28, 2024
View reviewed changes
Copy link
Member

@vplasencia vplasencia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @yagopajarino!

Thank you very much for the PR. Great work! 🙏

Just one comment, could you remove Chakra UI from the two apps and use css like in the current templates? The idea is to make it easier for developers to integrate the css library/framework they prefer, then using plain css is better for this case.

@yagopajarino
Copy link
Author

Hello @vplasencia! I changed the .env and the .gitignore of both templates. In upcoming days I'll be replacing the chakra elements for plain html + css :)

@vplasencia
Copy link
Member

Hey @yagopajarino! Thank you very much. No rush, take your time.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vplasencia vplasencia vplasencia requested changes

Requested changes must be addressed to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Update UI code of cli-template-monorepo-ethers and cli-template-monorepo-subgraph
3 participants
@yagopajarino @vplasencia @cedoor