add on_exists param with behaviour fail, ignore and overwrite
#207
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
adamrtalbot
changed the title
on_exists param with behaviour fail, ignore and overwrite
adamrtalbot
force-pushed
the
add_on_exists_param
branch
from
9676083 to
a722ce1
Compare
|
@ejseqera I tried to use an enum to provide some typing but it ended up feeling messier than I would like. It works well now and we can extend it to move behaviours (e.g. |
adamrtalbot
commented
Mar 5, 2025
adamrtalbot
commented
Mar 5, 2025
adamrtalbot
commented
Mar 5, 2025
adamrtalbot
commented
Mar 5, 2025
adamrtalbot
commented
Mar 5, 2025
adamrtalbot
commented
Mar 5, 2025
adamrtalbot
commented
Mar 5, 2025
adamrtalbot
commented
Mar 5, 2025
adamrtalbot
commented
Mar 5, 2025
adamrtalbot
commented
Mar 5, 2025
Co-authored-by: Adam Talbot <[email protected]>
Co-authored-by: Adam Talbot <[email protected]>
ejseqera
approved these changes
Mar 5, 2025
Co-authored-by: Esha Joshi <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds a feature where you can customize the behaviour when a resource exists. It has three options:
fail(default): Fail and halt seqerakitignore: Keep going and ignore the erroroverwrite: Use the existing overwrite behaviourWith this, we can repeatedly set up a 'showcase' and it will only create resources where they don't exist and launch pipelines, meaning we can be fairly frugal with resource set up.
The downside is status drift may occur, where the platform resources have diverged from the YAML templates which will not be captured and will be ignored by seqerakit. Not ideal, but a problem even for things like Terraform.