Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update docs for react_router using SSR #1632

Closed
jeremylynch opened this issue Jun 17, 2024 · 4 comments
Closed

Update docs for react_router using SSR #1632

jeremylynch opened this issue Jun 17, 2024 · 4 comments

Comments

@jeremylynch
Copy link

The current docs for react-router are outdated and incomplete: https://www.shakacode.com/react-on-rails/docs/javascript/react-router/

It would be great to update the following:

  • Update to use React router v7
  • Update redux to use configureStore rather than createStore (deprecated)
  • Show recommended way of setting up redux store when using react_on_rails

And a full end-to-end example of setting react_router with SSR would be fantastic!

@justin808
Copy link
Member

You are right! @jeremylynch any chance that you could add a PR?

BTW -- nice profile picture! I'm a surfer as well.

@jeremylynch
Copy link
Author

Thanks Justin!

I would happily do so, but I couldn't get this to work despite much trial and error.

Are there any example apps which show a working version of this? If I can find one I can update the docs

@justin808
Copy link
Member

Yes, see https://github.com/shakacode/react-webpack-rails-tutorial

@jeremylynch
Copy link
Author

Thanks Justin! I will review

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants