Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make the unpack button idempotent on action history #23

Open
sharmaeklavya2 opened this issue Sep 13, 2021 · 0 comments
Open

Make the unpack button idempotent on action history #23

sharmaeklavya2 opened this issue Sep 13, 2021 · 0 comments
Labels
easy Easy to implement low priority Not important

Comments

@sharmaeklavya2
Copy link
Owner

If you press the 'unpack' button, items would be unpacked from the bins and arranged back in the inventory. This also appends an action to the action history, so that you can use undo/redo buttons.

However, we don't want to append 'unpack' to history when the bins are already empty. This will also signal the users that pressing the button didn't cause anything.

We can maybe also disable the unpack button if the bins are already empty and the items are already well-arranged in the inventory.

@sharmaeklavya2 sharmaeklavya2 added easy Easy to implement low priority Not important labels Sep 13, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
easy Easy to implement low priority Not important
Projects
None yet
Development

No branches or pull requests

1 participant