Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Efficient parameterizaton of ScmNumberFormat through ScmWriteControls #1041

Open
shirok opened this issue Jun 14, 2024 · 0 comments
Open

Efficient parameterizaton of ScmNumberFormat through ScmWriteControls #1041

shirok opened this issue Jun 14, 2024 · 0 comments

Comments

@shirok
Copy link
Owner

shirok commented Jun 14, 2024

ScmNumberFormat allows to customize details of number to string and vice versa. From REPL, the user can change a few parameters of ScmNumberFormat via write-controls.

As we expose more parametres, it'd be tedious to mirror them in write-controls, and transfer them to ScmNumberFormat every time the number needs to be written. Rather, we may embed ScmNumberFormat in ScmWriteControls, and its getter/setter takes care of conversions. Then, we can just pass the pointer into ScmWriteControls in Scm__WritePrimitive() when we call Scm_PrintNumber.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant