Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Attach stack trace to a condition selectively #1079

Open
shirok opened this issue Nov 21, 2024 · 0 comments
Open

Attach stack trace to a condition selectively #1079

shirok opened this issue Nov 21, 2024 · 0 comments

Comments

@shirok
Copy link
Owner

shirok commented Nov 21, 2024

Currently, if we let Scm_Eval/Scm_Load to catch errors (that is, no "propagate error" flag), original stack trace is lost. (Cf. #521 ). We don't want to attach stack trace to the thrown condition unconditionally, for taking stack trace is expensive.

However, we may use a dynamilally scoped flag that tells VM to save the stack trace (or, save the continuation chain and keep it) in the condition. Especially, Scm_Load is typically load programs but does not execute long-running code, so it is less critical for error performance.

shirok added a commit that referenced this issue Nov 27, 2024
#1081

This is a temporary solution.  We need to repeat cleanup code
for `SCM_UNWIND_PROTECT` and error-trapping `Scm_Load` call, which
is awkward.

Better solution is with the line of #1079,
but that depends on continuation management overhaul.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant