We read every piece of feedback, and take your input very seriously.
To see all available qualifiers, see our documentation.
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Currently, the library can raise a Faraday::TimeoutError.
Faraday::TimeoutError
In the RaiseError middleware we catch Faraday::ConnectionFailed and remap it to ClickHouse::NetworkException:
RaiseError
Faraday::ConnectionFailed
ClickHouse::NetworkException
click_house/lib/click_house/middleware/raise_error.rb
Line 13 in 663b72d
However, TimeoutError isn't a descendant of ConnectionFailed:
TimeoutError
ConnectionFailed
https://github.com/lostisland/faraday/blob/ea30bd0b543882f1cf26e75ac4e46e0705fa7e68/lib/faraday/error.rb#L132
I suggest we also catch Faraday::TimeoutError (and perhaps a few more Faraday errors?) and remap it to ClickHouse errors
ClickHouse
The text was updated successfully, but these errors were encountered:
No branches or pull requests
Currently, the library can raise a
Faraday::TimeoutError
.In the
RaiseError
middleware we catchFaraday::ConnectionFailed
and remap it toClickHouse::NetworkException
:click_house/lib/click_house/middleware/raise_error.rb
Line 13 in 663b72d
However,
TimeoutError
isn't a descendant ofConnectionFailed
:https://github.com/lostisland/faraday/blob/ea30bd0b543882f1cf26e75ac4e46e0705fa7e68/lib/faraday/error.rb#L132
I suggest we also catch
Faraday::TimeoutError
(and perhaps a few more Faraday errors?) and remap it toClickHouse
errorsThe text was updated successfully, but these errors were encountered: