Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

eslint-config-angular: peer dependencies can't be resolved #8

Closed
chintankavathia opened this issue Jan 9, 2025 · 3 comments
Closed

Comments

@chintankavathia
Copy link
Member

The eslint-config-angular peerDependencies if copied as it is to install using npm will throw an error because
v2.26.0 of eslint-plugin-import doesn't include support for eslint@9

"peerDependencies": {
    "@eslint/js": "^9.9.1",
    "angular-eslint": "^18.1.0 || ^19.0.0",
    "eslint": "^9.9.1",
    "eslint-plugin-import": "2.26.0", // this only allows eslint version upto ^8
    "eslint-plugin-jsdoc": "^50.2.2",
    "eslint-plugin-prefer-arrow": "^1.2.3",
    "typescript-eslint": "^8.0.0"
  }
@timowolf
Copy link
Member

timowolf commented Jan 9, 2025

Same for npm install @siemens/[email protected]. @spike-rabbit It seems we need to undo the last patch.

Can we setup an e-2-e test that generates a new angular project using ng and adds all our configs via npm and yarn ?

@spike-rabbit
Copy link
Member

This was changed by intention: import-js/eslint-plugin-import#2685

In our code this bug leads to resort imports in every file and it also conflicts with the sorting build in IDEs (at least webstorm).
So using a newer broken version is not an option in my opinion. Instead we should either provide an upstream fix or just use another package, like https://github.com/azat-io/eslint-plugin-perfectionist

@timowolf
Copy link
Member

Closing, we changed it back in #11 and prepare for using the aslant-plugin-perfectionist.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants