Skip to content

Commit e918caa

Browse files
authored
Merge pull request #51 from siemens/feat/adapt-sentry-24.8.0
refactor: adapt sentry tests to 24.8.0
2 parents df07034 + 2ecd9ea commit e918caa

File tree

7 files changed

+123
-110
lines changed

7 files changed

+123
-110
lines changed

.gitignore

-1
Original file line numberDiff line numberDiff line change
@@ -8,5 +8,4 @@ venv
88
.coverage
99
.vscode/
1010
# Fetched from upstream
11-
requirements-sentry.txt
1211
tests/conftest.py

.gitmodules

+5
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,5 @@
1+
[submodule "deps/sentry"]
2+
path = deps/sentry
3+
url = https://github.com/getsentry/sentry.git
4+
# This is here for renovate
5+
branch = 24.8.0

Makefile

+3-5
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,3 @@
1-
SENTRY_VERSION := 24.2.0
2-
31
.PHONY: clean deps
42

53
# Upstream no longer tracks its own dependencies in the package as dev extras,
@@ -9,9 +7,9 @@ SENTRY_VERSION := 24.2.0
97
# use outside their own tests, but we need their fixtures. We fetch them into
108
# our own namespace here.
119
deps:
12-
curl -L -o requirements-sentry.txt https://github.com/getsentry/sentry/raw/$(SENTRY_VERSION)/requirements-dev-frozen.txt
13-
curl -L -o tests/conftest.py https://github.com/getsentry/sentry/raw/$(SENTRY_VERSION)/tests/conftest.py
14-
poetry run pip install -r requirements-sentry.txt
10+
git submodule update --init
11+
poetry run pip install -r deps/sentry/requirements-dev-frozen.txt -e deps/sentry
12+
cp -f deps/sentry/tests/conftest.py tests/conftest.py
1513

1614
clean:
1715
rm -rf *.egg-info src/*.egg-info

deps/sentry

Submodule sentry added at 1d52e8e

oidc/views.py

+1-2
Original file line numberDiff line numberDiff line change
@@ -70,8 +70,7 @@ def oidc_configure_view(
7070
else:
7171
domains = config.get("domains")
7272
return DeferredResponse(
73-
"oidc/configure.html",
74-
{"provider_name": ISSUER or "", "domains": domains or []}
73+
"oidc/configure.html", {"provider_name": ISSUER or "", "domains": domains or []}
7574
)
7675

7776

poetry.lock

+106-100
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

pyproject.toml

+7-2
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
11
[tool.poetry]
22
name = "sentry-auth-oidc"
3-
version = "8.1.0"
3+
version = "9.0.0"
44
description = "OpenID Connect authentication provider for Sentry"
55
authors = [
66
"Max Wittig <[email protected]>",
@@ -19,6 +19,9 @@ packages = [
1919
{ include = "oidc" }
2020
]
2121

22+
[tool.black]
23+
extend-exclude = "deps"
24+
2225
[tool.poetry.dependencies]
2326
python = "^3.11"
2427

@@ -30,7 +33,6 @@ flake8 = "^3.8.4"
3033
[tool.poetry.group.test.dependencies]
3134
codecov = "^2.1.12"
3235
pytest = "^7.1.3"
33-
sentry = {git = "https://github.com/getsentry/sentry.git", rev = "24.2.0"}
3436
fixtures = "^4.1.0"
3537

3638
[tool.isort]
@@ -39,6 +41,9 @@ profile = "black"
3941
[tool.poetry.plugins."sentry.apps"]
4042
"oidc" = "oidc.apps.Config"
4143

44+
[tool.pytest.ini_options]
45+
testpaths = ["tests"]
46+
4247
[build-system]
4348
requires = ["poetry-core>=1.0.0"]
4449
build-backend = "poetry.core.masonry.api"

0 commit comments

Comments
 (0)