Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Localizable.strings keyboard_shortcuts_can_be_changed for Ventura #97

Open
stammy opened this issue Oct 14, 2022 · 9 comments
Open

Comments

@stammy
Copy link

stammy commented Oct 14, 2022

For users on Ventura, instructions for how to change an existing system-wide shortcut are a bit different since System Preferences has been renamed to System Settings and the Shortcuts has been modified a bit as well.

"keyboard_shortcuts_can_be_changed" = "Most system-wide keyboard shortcuts can be changed in “System Preferences › Keyboard › Shortcuts”.";

should become:

"keyboard_shortcuts_can_be_changed" = "Most system-wide keyboard shortcuts can be changed in “System Settings › Keyboard › Keyboard Shortcuts…”.";

@sindresorhus
Copy link
Owner

sindresorhus commented Oct 20, 2022

English was updated in v1.8.0.

I'll need others to handle the localisations.

@sindresorhus
Copy link
Owner

@isametry
Copy link
Contributor

isametry commented Oct 20, 2022

I've changed the word in Czech and opened a PR. (#99)

@sindresorhus
Copy link
Owner

Note that you also need update the last part from Shortcuts to Keyboard Shortcuts.

isametry added a commit to isametry/KeyboardShortcuts that referenced this issue Oct 20, 2022
@2Grey
Copy link
Contributor

2Grey commented Oct 20, 2022

Does it make sense to add a new localization string for macOS 13.0+?

Because, otherwise the current localized text will become irrelevant for older versions of macOS.

@sindresorhus
Copy link
Owner

Does it make sense to add a new localization string for macOS 13.0+?

For simplicity, I have decided to just switch to the macOS 13 strings. This text is not super important and the user should be able to figure it out regardless.

@2Grey
Copy link
Contributor

2Grey commented Oct 20, 2022

Ok, got you.

Also there isn't need to change Russian localization, because for Russian language name of menu items didn't change.

@fejese
Copy link
Contributor

fejese commented Oct 22, 2022

I'm happy to take a look at this but I don't have Ventura yet to confirm how the Hungarian menu changed

@fejese
Copy link
Contributor

fejese commented Jan 29, 2023

finally got around to check: Hungarian translation is up to date too

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

6 participants
@stammy @sindresorhus @fejese @2Grey @isametry and others