Skip to content
This repository was archived by the owner on Jan 16, 2018. It is now read-only.

Commit b1bd64c

Browse files
authored
Merge pull request #403 from zzarcon/handle_react_dependencies
Try to improve React dependencies handling
2 parents 1d16fde + cc9dd38 commit b1bd64c

File tree

4 files changed

+18
-7
lines changed

4 files changed

+18
-7
lines changed

bin/sk-tests-perf

+2
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,2 @@
1+
#!/bin/sh
2+
karma start --perf

karma.conf.js

+1-1
Original file line numberDiff line numberDiff line change
@@ -14,7 +14,7 @@ module.exports = function (config) {
1414
};
1515

1616
if (process.argv.indexOf('--perf') > -1) {
17-
files = [require.resolve('../benchmark/benchmark.js'), 'test/perf.js'];
17+
files = ['test/perf.js'];
1818
preprocessors = {
1919
'test/perf.js': ['webpack', 'sourcemap'],
2020
};

package.json

+1
Original file line numberDiff line numberDiff line change
@@ -55,6 +55,7 @@
5555
"sk-server": "bin/sk-server",
5656
"sk-tests": "bin/sk-tests",
5757
"sk-tests-watch": "bin/sk-tests-watch",
58+
"sk-tests-perf": "bin/sk-tests-perf",
5859
"sk-lint": "bin/sk-lint"
5960
},
6061
"scripts": {

webpack.config.js

+14-6
Original file line numberDiff line numberDiff line change
@@ -3,6 +3,19 @@ const path = require('path');
33
const webpack = require('webpack');
44
const pkg = require(path.join(process.cwd(), 'package.json'));
55
const shouldMininimize = process.argv.indexOf('--min') !== -1;
6+
const plugins = [new webpack.optimize.UglifyJsPlugin({
7+
include: /\.min\.js$/,
8+
minimize: true,
9+
})];
10+
11+
if (process.argv.indexOf('--perf')) {
12+
plugins.push(new webpack.DefinePlugin({
13+
'process.env': {
14+
'NODE_ENV': JSON.stringify('production')
15+
}
16+
}));
17+
}
18+
619
const standardConfig = {
720
devtool: 'source-map',
821
entry: {
@@ -31,12 +44,7 @@ const standardConfig = {
3144
},
3245
}],
3346
},
34-
plugins: [
35-
new webpack.optimize.UglifyJsPlugin({
36-
include: /\.min\.js$/,
37-
minimize: true,
38-
}),
39-
],
47+
plugins
4048
};
4149

4250
if (shouldMininimize) {

0 commit comments

Comments
 (0)