From 53e07e61ac6405c40b06d86f2ff32720b4a7d157 Mon Sep 17 00:00:00 2001
From: OSS-Bot <svc-oss-bot@slack-corp.com>
Date: Fri, 6 Dec 2024 08:03:44 +0000
Subject: [PATCH 1/3] Update plugin lint to v8.8.0-rc01
---
gradle/libs.versions.toml | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/gradle/libs.versions.toml b/gradle/libs.versions.toml
index 3052b653..8529ea9c 100644
--- a/gradle/libs.versions.toml
+++ b/gradle/libs.versions.toml
@@ -11,7 +11,7 @@ lint = "31.8.0-alpha07"
buildConfig = { id = "com.github.gmazzo.buildconfig", version = "5.5.0" }
detekt = { id = "io.gitlab.arturbosch.detekt", version = "1.23.7" }
dokka = { id = "org.jetbrains.dokka", version = "1.9.20" }
-lint = { id = "com.android.lint", version = "8.8.0-alpha09" }
+lint = { id = "com.android.lint", version = "8.8.0-rc01" }
kotlin-jvm = { id = "org.jetbrains.kotlin.jvm", version.ref = "kotlin" }
ksp = { id = "com.google.devtools.ksp", version = "2.0.21-1.0.27" }
mavenPublish = { id = "com.vanniktech.maven.publish", version = "0.30.0" }
From e71ea836b11b8feafd0b543cb4c6142bae5b6bdd Mon Sep 17 00:00:00 2001
From: Zac Sweers <pandanomic@gmail.com>
Date: Thu, 12 Dec 2024 22:47:04 -0500
Subject: [PATCH 2/3] Update to latest
---
gradle/libs.versions.toml | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/gradle/libs.versions.toml b/gradle/libs.versions.toml
index 8529ea9c..377e25f5 100644
--- a/gradle/libs.versions.toml
+++ b/gradle/libs.versions.toml
@@ -5,13 +5,13 @@ jdk = "22"
# lint checks must target JDK 17, but the runtime should remain 11
lintJvmTarget = "17"
runtimeJvmTarget = "11"
-lint = "31.8.0-alpha07"
+lint = "31.9.0-alpha05"
[plugins]
buildConfig = { id = "com.github.gmazzo.buildconfig", version = "5.5.0" }
detekt = { id = "io.gitlab.arturbosch.detekt", version = "1.23.7" }
dokka = { id = "org.jetbrains.dokka", version = "1.9.20" }
-lint = { id = "com.android.lint", version = "8.8.0-rc01" }
+lint = { id = "com.android.lint", version = "8.9.0-alpha05" }
kotlin-jvm = { id = "org.jetbrains.kotlin.jvm", version.ref = "kotlin" }
ksp = { id = "com.google.devtools.ksp", version = "2.0.21-1.0.27" }
mavenPublish = { id = "com.vanniktech.maven.publish", version = "0.30.0" }
From d9f15e2c68129a7db3cc38a254053446a16e2118 Mon Sep 17 00:00:00 2001
From: Zac Sweers <pandanomic@gmail.com>
Date: Thu, 12 Dec 2024 22:48:52 -0500
Subject: [PATCH 3/3] Update baselines
---
slack-lint-checks/lint-baseline.xml | 144 ++--------------------------
1 file changed, 6 insertions(+), 138 deletions(-)
diff --git a/slack-lint-checks/lint-baseline.xml b/slack-lint-checks/lint-baseline.xml
index 38562ebc..c82b2176 100644
--- a/slack-lint-checks/lint-baseline.xml
+++ b/slack-lint-checks/lint-baseline.xml
@@ -1,5 +1,5 @@
<?xml version="1.0" encoding="UTF-8"?>
-<issues format="6" by="lint 8.5.0-beta01" type="baseline" client="gradle" dependencies="false" name="AGP (8.5.0-beta01)" variant="all" version="8.5.0-beta01">
+<issues format="6" by="lint 8.9.0-alpha05" type="baseline" client="gradle" dependencies="false" name="AGP (8.9.0-alpha05)" variant="all" version="8.9.0-alpha05">
<issue
id="LintDocExample"
@@ -118,7 +118,7 @@
errorLine2=" ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~">
<location
file="src/main/java/slack/lint/DoNotCallProvidersDetector.kt"
- line="42"
+ line="27"
column="10"/>
</issue>
@@ -228,7 +228,7 @@
errorLine2=" ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~">
<location
file="src/main/java/slack/lint/resources/FullyQualifiedResourceDetector.kt"
- line="150"
+ line="152"
column="12"/>
</issue>
@@ -239,7 +239,7 @@
errorLine2=" ~~~~~~~~~~~~~~~~~~~~~~~~~~~~">
<location
file="src/main/java/slack/lint/resources/FullyQualifiedResourceDetector.kt"
- line="152"
+ line="154"
column="14"/>
</issue>
@@ -250,7 +250,7 @@
errorLine2=" ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~">
<location
file="src/main/java/slack/lint/resources/FullyQualifiedResourceDetector.kt"
- line="154"
+ line="156"
column="14"/>
</issue>
@@ -448,7 +448,7 @@
errorLine2=" ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~">
<location
file="src/main/java/slack/lint/retrofit/RetrofitUsageDetector.kt"
- line="155"
+ line="176"
column="10"/>
</issue>
@@ -540,138 +540,6 @@
column="38"/>
</issue>
- <issue
- id="LintImplTrimIndent"
- message="No need to call `.trimIndent()` in issue registration strings; they are already trimmed by indent by lint when displaying to users. Instead, call `.indented()` on the surrounding `kotlin()` test file construction"
- errorLine1=" .trimIndent()"
- errorLine2=" ~~~~~~~~~~~~">
- <location
- file="src/test/java/slack/lint/FragmentDaggerFieldInjectionDetectorTest.kt"
- line="90"
- column="16"/>
- </issue>
-
- <issue
- id="LintImplTrimIndent"
- message="No need to call `.trimIndent()` in issue registration strings; they are already trimmed by indent by lint when displaying to users. Instead, call `.indented()` on the surrounding `java()` test file construction"
- errorLine1=" .trimIndent()"
- errorLine2=" ~~~~~~~~~~~~">
- <location
- file="src/test/java/slack/lint/FragmentDaggerFieldInjectionDetectorTest.kt"
- line="140"
- column="16"/>
- </issue>
-
- <issue
- id="LintImplTrimIndent"
- message="No need to call `.trimIndent()` in issue registration strings; they are already trimmed by indent by lint when displaying to users. Instead, call `.indented()` on the surrounding `kotlin()` test file construction"
- errorLine1=" .trimIndent()"
- errorLine2=" ~~~~~~~~~~~~">
- <location
- file="src/test/java/slack/lint/FragmentDaggerFieldInjectionDetectorTest.kt"
- line="210"
- column="16"/>
- </issue>
-
- <issue
- id="LintImplTrimIndent"
- message="No need to call `.trimIndent()` in issue registration strings; they are already trimmed by indent by lint when displaying to users. Instead, call `.indented()` on the surrounding `java()` test file construction"
- errorLine1=" .trimIndent()"
- errorLine2=" ~~~~~~~~~~~~">
- <location
- file="src/test/java/slack/lint/FragmentDaggerFieldInjectionDetectorTest.kt"
- line="271"
- column="16"/>
- </issue>
-
- <issue
- id="LintImplTrimIndent"
- message="No need to call `.trimIndent()` in issue registration strings; they are already trimmed by indent by lint when displaying to users. Instead, call `.indented()` on the surrounding `java()` test file construction"
- errorLine1=" .trimIndent()"
- errorLine2=" ~~~~~~~~~~~~">
- <location
- file="src/test/java/slack/lint/FragmentDaggerFieldInjectionDetectorTest.kt"
- line="327"
- column="16"/>
- </issue>
-
- <issue
- id="LintImplTrimIndent"
- message="No need to call `.trimIndent()` in issue registration strings; they are already trimmed by indent by lint when displaying to users. Instead, call `.indented()` on the surrounding `kotlin()` test file construction"
- errorLine1=" .trimIndent()"
- errorLine2=" ~~~~~~~~~~~~">
- <location
- file="src/test/java/slack/lint/FragmentDaggerFieldInjectionDetectorTest.kt"
- line="377"
- column="16"/>
- </issue>
-
- <issue
- id="LintImplTrimIndent"
- message="No need to call `.trimIndent()` in issue registration strings; they are already trimmed by indent by lint when displaying to users. Instead, call `.indented()` on the surrounding `java()` test file construction"
- errorLine1=" .trimIndent()"
- errorLine2=" ~~~~~~~~~~~~">
- <location
- file="src/test/java/slack/lint/FragmentDaggerFieldInjectionDetectorTest.kt"
- line="462"
- column="16"/>
- </issue>
-
- <issue
- id="LintImplTrimIndent"
- message="No need to call `.trimIndent()` in issue registration strings; they are already trimmed by indent by lint when displaying to users. Instead, call `.indented()` on the surrounding `java()` test file construction"
- errorLine1=" .trimIndent()"
- errorLine2=" ~~~~~~~~~~~~">
- <location
- file="src/test/java/slack/lint/FragmentDaggerFieldInjectionDetectorTest.kt"
- line="512"
- column="16"/>
- </issue>
-
- <issue
- id="LintImplTrimIndent"
- message="No need to call `.trimIndent()` in issue registration strings; they are already trimmed by indent by lint when displaying to users. Instead, call `.indented()` on the surrounding `kotlin()` test file construction"
- errorLine1=" .trimIndent()"
- errorLine2=" ~~~~~~~~~~~~">
- <location
- file="src/test/java/slack/lint/MainScopeUsageDetectorTest.kt"
- line="47"
- column="16"/>
- </issue>
-
- <issue
- id="LintImplTrimIndent"
- message="No need to call `.trimIndent()` in issue registration strings; they are already trimmed by indent by lint when displaying to users. Instead, call `.indented()` on the surrounding `kotlin()` test file construction"
- errorLine1=" .trimIndent(),"
- errorLine2=" ~~~~~~~~~~~~">
- <location
- file="src/test/java/slack/lint/MainScopeUsageDetectorTest.kt"
- line="90"
- column="16"/>
- </issue>
-
- <issue
- id="LintImplTrimIndent"
- message="No need to call `.trimIndent()` in issue registration strings; they are already trimmed by indent by lint when displaying to users. Instead, call `.indented()` on the surrounding `kotlin()` test file construction"
- errorLine1=" .trimIndent()"
- errorLine2=" ~~~~~~~~~~~~">
- <location
- file="src/test/java/slack/lint/RawDispatchersUsageDetectorTest.kt"
- line="68"
- column="16"/>
- </issue>
-
- <issue
- id="LintImplTrimIndent"
- message="No need to call `.trimIndent()` in issue registration strings; they are already trimmed by indent by lint when displaying to users. Instead, call `.indented()` on the surrounding `kotlin()` test file construction"
- errorLine1=" .trimIndent(),"
- errorLine2=" ~~~~~~~~~~~~">
- <location
- file="src/test/java/slack/lint/RawDispatchersUsageDetectorTest.kt"
- line="131"
- column="16"/>
- </issue>
-
<issue
id="LintImplUseUast"
message="Don't call PsiField#getInitializer(); you must use UAST instead. If you don't have a UField call UastFacade.getInitializerBody(field)"