Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

SNOW-1553756: SNOW-1017659 replace github.com/99designs/keyring with a different implementation #1183

Open
sfc-gh-dszmolka opened this issue Jul 24, 2024 · 5 comments
Open

SNOW-1553756: SNOW-1017659 replace github.com/99designs/keyring with a different implementation #1183

sfc-gh-dszmolka opened this issue Jul 24, 2024 · 5 comments
Assignees
@sfc-gh-snow-drivers-warsaw-dl
Labels
enhancement The issue is a request for improvement or a new feature status-triage_done Initial triage done, will be further handled by the driver team

Comments

@sfc-gh-dszmolka
Copy link
Contributor

Some headache coming from unaddressed bug from the said library, see:
#773
#1182

This item is to track the effort of replacing it with a different implementation.
@sfc-gh-dszmolka sfc-gh-dszmolka added the enhancement The issue is a request for improvement or a new feature label Jul 24, 2024
@github-actions github-actions bot changed the title replace github.com/99designs/keyring with a different implementation SNOW-1553756: replace github.com/99designs/keyring with a different implementation Jul 24, 2024
@sfc-gh-dszmolka
Copy link
Contributor Author

(created issue)

@sfc-gh-dszmolka sfc-gh-dszmolka self-assigned this Jul 24, 2024
@sfc-gh-dszmolka sfc-gh-dszmolka added the status-triage Issue is under initial triage label Jul 24, 2024
@sfc-gh-dszmolka sfc-gh-dszmolka changed the title SNOW-1553756: replace github.com/99designs/keyring with a different implementation SNOW-1553756: SNOW-1017659 replace github.com/99designs/keyring with a different implementation Jul 24, 2024
@sfc-gh-dszmolka sfc-gh-dszmolka mentioned this issue Jul 24, 2024
Closed
@sfc-gh-dszmolka sfc-gh-dszmolka added status-triage_done Initial triage done, will be further handled by the driver team and removed status-triage Issue is under initial triage labels Jul 25, 2024
@fairclothjm
Copy link

@sfc-gh-dszmolka Hello, any update on this? Is this on your roadmap? Thanks!

@sfc-gh-dszmolka
Copy link
Contributor Author

not for the coming months for sure, unfortunately

@fairclothjm fairclothjm mentioned this issue Jan 9, 2025
Merged
6 tasks
Closed
6 tasks
@sfc-gh-dszmolka
Copy link
Contributor Author

(still not on the roadmap for the next months)

sfc-gh-dszmolka added a commit that referenced this issue Jan 30, 2025
@sfc-gh-dszmolka
SNOW-1553756 #1183 for the full story
737ca2a 
* use forked keyring from 99designs/keyring#103 (comment) which eliminates Linux kwallet/secretservice, which we don't use anyways but causes headache with dbus upon keyring init()
@sfc-gh-dszmolka sfc-gh-dszmolka mentioned this issue Jan 30, 2025
Closed
2 tasks
@sfc-gh-dszmolka
Copy link
Contributor Author

sfc-gh-dszmolka commented Feb 3, 2025 •
edited
Loading

PR #1296 to use Jeffail's workaround of a forked keyring without kwallet and secretservice, which eliminates the issue for us. Until there will be resources to do a proper reimplementation without 99designs/keyring.

edit: did not work out, we still need to look for the solution.

@sfc-gh-dszmolka sfc-gh-dszmolka added the status-pr_pending_merge A PR is made and is under review label Feb 3, 2025
@sfc-gh-dszmolka sfc-gh-dszmolka removed the status-pr_pending_merge A PR is made and is under review label Feb 11, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@sfc-gh-snow-drivers-warsaw-dl sfc-gh-snow-drivers-warsaw-dl

Labels
enhancement The issue is a request for improvement or a new feature status-triage_done Initial triage done, will be further handled by the driver team
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@fairclothjm @sfc-gh-dszmolka @sfc-gh-snow-drivers-warsaw-dl