Skip to content

Commit cdb5535

Browse files
test: adapter.close() is now called by io.close()
Related: socketio/socket.io@bf64870
1 parent 5e82a3b commit cdb5535

File tree

3 files changed

+56
-46
lines changed

3 files changed

+56
-46
lines changed

package-lock.json

+53-34
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

test/index.ts

+1-4
Original file line numberDiff line numberDiff line change
@@ -44,10 +44,7 @@ export function testSuite(createAdapter: any) {
4444
});
4545

4646
it("broadcasts to all clients in a namespace", (done) => {
47-
const partialDone = times(3, () => {
48-
servers.forEach((server) => server.of("/custom").adapter.close());
49-
done();
50-
});
47+
const partialDone = times(3, done);
5148

5249
servers.forEach((server) => server.of("/custom"));
5350

test/util.ts

+2-8
Original file line numberDiff line numberDiff line change
@@ -63,14 +63,8 @@ export function setup(createAdapter: any) {
6363
serverSockets,
6464
clientSockets,
6565
cleanup: () => {
66-
servers.forEach((server) => {
67-
// @ts-ignore
68-
server.httpServer.close();
69-
server.of("/").adapter.close();
70-
});
71-
clientSockets.forEach((socket) => {
72-
socket.disconnect();
73-
});
66+
servers.forEach((server) => server.close());
67+
clientSockets.forEach((socket) => socket.disconnect());
7468
redisCleanupFunctions.forEach((fn) => fn());
7569
},
7670
});

0 commit comments

Comments
 (0)