improve scripts (#1083)

- use `bash` instead of `sh`
  more info or reason see Shell Style Guide of google:
  https://google.github.io/styleguide/shellguide.html#which-shell-to-use
- fix shellcheck warning
  - use -z instead of `! -n`
  - SC2086 Double quote to prevent globbing and word splitting
- check_format.sh
  - call `git status` one time

Author: oldratlee

.github/workflows/maven.yml

@@ -20,7 +20,7 @@ jobs:
       with:
         java-version: 1.8
     - name: Build with Maven
-      run: ./mvnw clean install -Pci-install -B -U -e && sh ./tools/check_format.sh
+      run: ./mvnw clean install -Pci-install -B -U -e && bash ./tools/check_format.sh
     - name: Test with Maven
       run: ./mvnw package -Pci-test
     - name: Codecov

.travis.yml

@@ -12,7 +12,7 @@ cache:
 
 install:
   - ./mvnw clean install -Pci-install -B -U -e
-  - sh ./tools/check_format.sh
+  - bash ./tools/check_format.sh
 
 script:
   - ./mvnw package -Pci-test

registry/registry-nacos/src/test/scripts/start-nacos-server.sh

@@ -4,5 +4,5 @@ echo "Downloading Nacos 0.6.0"
 wget https://github.com/alibaba/nacos/releases/download/0.6.0/nacos-server-0.6.0.zip -O nacos-server-0.6.0.zip
 unzip -qo nacos-server-0.6.0.zip
 
-nohup bash $PWD/nacos/bin/startup.sh -m standalone >> $PWD/nacos/start.out 2>&1 &
-sleep 10
+nohup bash "$PWD"/nacos/bin/startup.sh -m standalone >> "$PWD"/nacos/start.out 2>&1 &
+sleep 10

registry/registry-nacos/src/test/scripts/stop-nacos-server.sh

@@ -1,6 +1,7 @@
 #!/bin/bash
 
-if [ -f "$PWD/nacos/bin/shutdown.sh" ]
-then
-    bash $PWD/nacos/bin/shutdown.sh
+readonly shutdown_script="$PWD/nacos/bin/shutdown.sh"
+
+if [ -f "$shutdown_script" ]; then
+    bash "$shutdown_script"
 fi

tools/change_version.sh

@@ -1,58 +1,61 @@
 #!/bin/bash
-shellDir=$(cd "$(dirname "$0")"; pwd)
+
+shellDir=$(
+  cd "$(dirname "$0")"
+  pwd
+)
 
 shopt -s expand_aliases
-if [ ! -n "$1" ] ;then
-	echo "Please enter a version"
- 	exit 1	
+if [ -z "$1" ]; then
+  echo "Please enter a version"
+  exit 1
 else
-  	echo "The version is $1 !"
+  echo "The version is $1 !"
 fi
 
-if [ `uname` == "Darwin" ] ;then
- 	echo "This is OS X"
- 	alias sed='sed -i ""'
+if [ "$(uname)" == "Darwin" ]; then
+  echo "This is OS X"
+  alias sed='sed -i ""'
 else
- 	echo "This is Linux"
- 	alias sed='sed -i'
+  echo "This is Linux"
+  alias sed='sed -i'
 fi
 
 echo "Change version in root pom.xml ===>"
-sed "s/<revision>.*<\/revision>/<revision>$1<\/revision>/" $shellDir/../pom.xml
+sed "s/<revision>.*<\/revision>/<revision>$1<\/revision>/" "$shellDir"/../pom.xml
 
 echo "Change version in sofa-rpc-all ===>"
-sed "/<project /,/<name/ s/<version>[^\$].*<\/version>/<version>$1<\/version>/" $shellDir/../all/pom.xml
+sed "/<project /,/<name/ s/<version>[^\$].*<\/version>/<version>$1<\/version>/" "$shellDir"/../all/pom.xml
 
 echo "Change version in sofa-rpc-bom ===>"
-sed "s/<revision>.*<\/revision>/<revision>$1<\/revision>/" $shellDir/../bom/pom.xml
-
+sed "s/<revision>.*<\/revision>/<revision>$1<\/revision>/" "$shellDir"/../bom/pom.xml
 
 # echo "Change version in MANIFEST.MF"
 # echo "Deal with MANIFEST.MF"
 # sed "s/Plugin-Version.*/Plugin-Version: $1.common/g" $shellDir/../sofa-rpc-plugin/src/main/resources/META-INF/MANIFEST.MF
 
 version_java_file="$shellDir/../core/api/src/main/java/com/alipay/sofa/rpc/common/Version.java"
-if [ -f $version_java_file ]; then
-
-    echo "=================="
-    echo " WARN: You need to modify \"core/api/src/main/java/com/alipay/sofa/rpc/common/Version.java\" "
-    echo "=================="
-
-    version_str=$(echo $1 | \sed -e "s/[^0-9\.]//g")
-    echo "VERSION is ${version_str}"
-    sed "s/\(VERSION[ ]*=[ ]*\"\).*$/\1${version_str}\";/g" $version_java_file
-    
-    # number and dot -> padding bugfix version -> padding minor version -> padding major version -> only leave number
-    rpc_version=$(echo $1 | \sed -e "s/[^0-9\.]//g" \
-        -e "s/\.\([0-9]\)$/\.0\1/" \
-        -e "s/\.\([0-9]\)\./\.0\1\./g" \
-        -e "s/^\([0-9]\)\./\1\./g" \
-        -e "s/[^0-9]//g")
-    echo "RPC_VERSION is ${rpc_version}"
-    sed "s/\(RPC_VERSION[ ]*=[ ]*\).*$/\1${rpc_version};/g" $version_java_file
-    
-    date_format=$(date  +"%Y%m%d%H%M%S")
-    build_version=${version_str}_${date_format}
-    echo "BUILD_VERSION is ${build_version}"
-    sed "s/\(BUILD_VERSION[ ]*=[ ]*\"\).*$/\1${build_version}\";/g" $version_java_file
+if [ -f "$version_java_file" ]; then
+
+  echo "=================="
+  echo " WARN: You need to modify \"core/api/src/main/java/com/alipay/sofa/rpc/common/Version.java\" "
+  echo "=================="
+
+  version_str=$(echo "$1" | \sed -e "s/[^0-9\.]//g")
+  echo "VERSION is ${version_str}"
+  sed "s/\(VERSION[ ]*=[ ]*\"\).*$/\1${version_str}\";/g" "$version_java_file"
+
+  # number and dot -> padding bugfix version -> padding minor version -> padding major version -> only leave number
+  rpc_version=$(echo "$1" | \sed -e "s/[^0-9\.]//g" \
+    -e "s/\.\([0-9]\)$/\.0\1/" \
+    -e "s/\.\([0-9]\)\./\.0\1\./g" \
+    -e "s/^\([0-9]\)\./\1\./g" \
+    -e "s/[^0-9]//g")
+  echo "RPC_VERSION is ${rpc_version}"
+  sed "s/\(RPC_VERSION[ ]*=[ ]*\).*$/\1${rpc_version};/g" "$version_java_file"
+
+  date_format=$(date +"%Y%m%d%H%M%S")
+  build_version=${version_str}_${date_format}
+  echo "BUILD_VERSION is ${build_version}"
+  sed "s/\(BUILD_VERSION[ ]*=[ ]*\"\).*$/\1${build_version}\";/g" "$version_java_file"
 fi

tools/check_format.sh

@@ -1,12 +1,14 @@
-#!/bin/sh
+#!/bin/bash
+set -eEuo pipefail
 
-BASEDIR=$(dirname $0)
+BASEDIR=$(dirname "$0")
+cd "${BASEDIR}"
 
-cd ${BASEDIR}
+git_status="$(git status --untracked-files=no --porcelain)"
 
 # make sure git has no un commit files
-if [ -n "$(git status --untracked-files=no --porcelain)" ]; then
-   echo "Please commit your change before run this shell, un commit files:"
-   git status --untracked-files=no --porcelain
-   exit 1
-fi
+if [ -n "$git_status" ]; then
+  echo "Please commit your change before run this shell, un commit files:"
+  echo "$git_status"
+  exit 1
+fi