Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

hermes init fails with cryptic error message in non-git directory #308

Open
zyzzyxdonta opened this issue Feb 3, 2025 · 0 comments
Open
Labels
bug Something isn't working

Comments

@zyzzyxdonta
Copy link
Contributor

zyzzyxdonta commented Feb 3, 2025

When running hermes init in a non-git directory, it fails with:

No connection adapters were found for ':///api/v4/version'

This is due to urlparse() not "failing" but rather returning empty strings, here:

parsed_url = urlparse(info.git_remote_url)

It might make sense to wrap urlparse() and raise an exception if either of scheme or netloc is not existent. (Or abort searching for git stuff way earlier.)

@zyzzyxdonta zyzzyxdonta added the bug Something isn't working label Feb 3, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

1 participant