Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Executor Helm Chart - kubernetesJob.node.tolerations doesn't render as expected #349

Open
anders-ni opened this issue Sep 11, 2023 · 0 comments

Comments

@anders-ni
Copy link

When setting the value for executor.kubernetesJob.node.tolerations it does not render in the configmap in the way that the executor pod is able to consume it.

I'm finding that if you set the following as the chart suggests:
tolerations: [{"key": "foo", "operator": "Equal", "value": "bar", "effect": "NoSchedule"}]
It will render as EXECUTOR_KUBERNETES_NODE_TOLERATIONS: map[effect:NoSchedule key:foo operator:Equal value:bar]
Causing your executor pod to throw invalid EXECUTOR_KUBERNETES_NODE_TOLERATIONS, failed to parse: invalid character 'm' looking for beginning of value into the logs and does not execute jobs.

If you do a manual edit of the configmap back to the original Json specified in the chart, then the jobs executor and respect the tolerations.

https://github.com/sourcegraph/deploy-sourcegraph-helm/blob/main/charts/sourcegraph-executor/k8s/values.yaml#L116-L117

I think the chart is incorrectly trying to render the json to yaml, when it should remain as json.
https://github.com/sourcegraph/deploy-sourcegraph-helm/blob/main/charts/sourcegraph-executor/k8s/templates/executor.ConfigMap.yaml#L26

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant