You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
When setting the value for executor.kubernetesJob.node.tolerations it does not render in the configmap in the way that the executor pod is able to consume it.
I'm finding that if you set the following as the chart suggests: tolerations: [{"key": "foo", "operator": "Equal", "value": "bar", "effect": "NoSchedule"}]
It will render as EXECUTOR_KUBERNETES_NODE_TOLERATIONS: map[effect:NoSchedule key:foo operator:Equal value:bar]
Causing your executor pod to throw invalid EXECUTOR_KUBERNETES_NODE_TOLERATIONS, failed to parse: invalid character 'm' looking for beginning of value into the logs and does not execute jobs.
If you do a manual edit of the configmap back to the original Json specified in the chart, then the jobs executor and respect the tolerations.
When setting the value for
executor.kubernetesJob.node.tolerations
it does not render in the configmap in the way that the executor pod is able to consume it.I'm finding that if you set the following as the chart suggests:
tolerations: [{"key": "foo", "operator": "Equal", "value": "bar", "effect": "NoSchedule"}]
It will render as
EXECUTOR_KUBERNETES_NODE_TOLERATIONS: map[effect:NoSchedule key:foo operator:Equal value:bar]
Causing your executor pod to throw
invalid EXECUTOR_KUBERNETES_NODE_TOLERATIONS, failed to parse: invalid character 'm' looking for beginning of value
into the logs and does not execute jobs.If you do a manual edit of the configmap back to the original Json specified in the chart, then the jobs executor and respect the tolerations.
https://github.com/sourcegraph/deploy-sourcegraph-helm/blob/main/charts/sourcegraph-executor/k8s/values.yaml#L116-L117
I think the chart is incorrectly trying to render the json to yaml, when it should remain as json.
https://github.com/sourcegraph/deploy-sourcegraph-helm/blob/main/charts/sourcegraph-executor/k8s/templates/executor.ConfigMap.yaml#L26
The text was updated successfully, but these errors were encountered: