From dd38ce896c70fdad1a3cc952d43171f6d9c73cd3 Mon Sep 17 00:00:00 2001 From: MilenVolf Date: Tue, 12 Nov 2024 20:54:34 +0300 Subject: [PATCH 1/2] Replace some obsolete TileAccess methods --- Robust.Client/Placement/Modes/AlignTileAny.cs | 9 +++++---- .../Placement/Modes/AlignTileEmpty.cs | 11 +++++------ Robust.Client/Placement/PlacementManager.cs | 6 +++--- Robust.Client/Placement/PlacementMode.cs | 5 +++-- .../Shared/Map/GridRotation_Tests.cs | 18 +++++++++--------- .../Shared/Physics/CollisionWake_Test.cs | 9 ++++++--- 6 files changed, 31 insertions(+), 27 deletions(-) diff --git a/Robust.Client/Placement/Modes/AlignTileAny.cs b/Robust.Client/Placement/Modes/AlignTileAny.cs index 89e239f1398..ff51aa89eb0 100644 --- a/Robust.Client/Placement/Modes/AlignTileAny.cs +++ b/Robust.Client/Placement/Modes/AlignTileAny.cs @@ -1,4 +1,5 @@ using System.Numerics; +using Robust.Shared.GameObjects; using Robust.Shared.Map; using Robust.Shared.Map.Components; @@ -14,16 +15,16 @@ public AlignTileAny(PlacementManager pMan) : base(pMan) { } public override void AlignPlacementMode(ScreenCoordinates mouseScreen) { // Go over diagonal size so when placing in a line it doesn't stop snapping. - const float SearchBoxSize = 2f; // size of search box in meters + const float searchBoxSize = 2f; // size of search box in meters - MouseCoords = ScreenToCursorGrid(mouseScreen).AlignWithClosestGridTile(SearchBoxSize, pManager.EntityManager, pManager.MapManager); + MouseCoords = ScreenToCursorGrid(mouseScreen).AlignWithClosestGridTile(searchBoxSize, pManager.EntityManager, pManager.MapManager); - var gridId = MouseCoords.GetGridUid(pManager.EntityManager); + var gridId = pManager.EntityManager.System().GetGrid(MouseCoords); if (!pManager.EntityManager.TryGetComponent(gridId, out var mapGrid)) return; - CurrentTile = mapGrid.GetTileRef(MouseCoords); + CurrentTile = pManager.EntityManager.System().GetTileRef(gridId.Value, mapGrid, MouseCoords); float tileSize = mapGrid.TileSize; //convert from ushort to float GridDistancing = tileSize; diff --git a/Robust.Client/Placement/Modes/AlignTileEmpty.cs b/Robust.Client/Placement/Modes/AlignTileEmpty.cs index c73e805758c..7de18033dda 100644 --- a/Robust.Client/Placement/Modes/AlignTileEmpty.cs +++ b/Robust.Client/Placement/Modes/AlignTileEmpty.cs @@ -1,6 +1,5 @@ using System.Numerics; using Robust.Shared.GameObjects; -using Robust.Shared.IoC; using Robust.Shared.Map; using Robust.Shared.Map.Components; using Robust.Shared.Maths; @@ -19,12 +18,12 @@ public override void AlignPlacementMode(ScreenCoordinates mouseScreen) MouseCoords = ScreenToCursorGrid(mouseScreen); var tileSize = 1f; - var gridIdOpt = MouseCoords.GetGridUid(pManager.EntityManager); + var gridIdOpt = pManager.EntityManager.System().GetGrid(MouseCoords); - if (gridIdOpt is EntityUid gridId && gridId.IsValid()) + if (gridIdOpt is { } gridId && gridId.IsValid()) { var mapGrid = pManager.EntityManager.GetComponent(gridId); - CurrentTile = mapGrid.GetTileRef(MouseCoords); + CurrentTile = pManager.EntityManager.System().GetTileRef(gridId, mapGrid ,MouseCoords); tileSize = mapGrid.TileSize; //convert from ushort to float } @@ -50,12 +49,12 @@ public override bool IsValidPosition(EntityCoordinates position) return false; } - var map = MouseCoords.GetMapId(pManager.EntityManager); + var map = pManager.EntityManager.System().GetMapId(MouseCoords); var bottomLeft = new Vector2(CurrentTile.X, CurrentTile.Y); var topRight = new Vector2(CurrentTile.X + 0.99f, CurrentTile.Y + 0.99f); var box = new Box2(bottomLeft, topRight); - return !EntitySystem.Get().AnyEntitiesIntersecting(map, box); + return !pManager.EntityManager.System().AnyEntitiesIntersecting(map, box); } } } diff --git a/Robust.Client/Placement/PlacementManager.cs b/Robust.Client/Placement/PlacementManager.cs index 7a7d5257f7e..b8633d9b71c 100644 --- a/Robust.Client/Placement/PlacementManager.cs +++ b/Robust.Client/Placement/PlacementManager.cs @@ -754,14 +754,14 @@ private void RequestPlacement(EntityCoordinates coordinates) if (CurrentPermission.IsTile) { - var gridIdOpt = coordinates.GetGridUid(EntityManager); + var gridIdOpt = EntityManager.System().GetGrid(coordinates); // If we have actually placed something on a valid grid... - if (gridIdOpt is EntityUid gridId && gridId.IsValid()) + if (gridIdOpt is { } gridId && gridId.IsValid()) { var grid = EntityManager.GetComponent(gridId); // no point changing the tile to the same thing. - if (grid.GetTileRef(coordinates).Tile.TypeId == CurrentPermission.TileType) + if (EntityManager.System().GetTileRef(gridId, grid, coordinates).Tile.TypeId == CurrentPermission.TileType) return; } diff --git a/Robust.Client/Placement/PlacementMode.cs b/Robust.Client/Placement/PlacementMode.cs index d29971d0ce5..f3e6ea67c76 100644 --- a/Robust.Client/Placement/PlacementMode.cs +++ b/Robust.Client/Placement/PlacementMode.cs @@ -197,8 +197,9 @@ public IEnumerable GridCoordinates() /// public TileRef GetTileRef(EntityCoordinates coordinates) { - var gridUidOpt = coordinates.GetGridUid(pManager.EntityManager); - return gridUidOpt is EntityUid gridUid && gridUid.IsValid() ? pManager.EntityManager.GetComponent(gridUid).GetTileRef(MouseCoords) + var gridUidOpt = pManager.EntityManager.System().GetGrid(coordinates); + return gridUidOpt is { } gridUid && gridUid.IsValid() + ? pManager.EntityManager.System().GetTileRef(gridUid, pManager.EntityManager.GetComponent(gridUid), MouseCoords) : new TileRef(gridUidOpt ?? EntityUid.Invalid, MouseCoords.ToVector2i(pManager.EntityManager, pManager.MapManager, pManager.EntityManager.System()), Tile.Empty); } diff --git a/Robust.UnitTesting/Shared/Map/GridRotation_Tests.cs b/Robust.UnitTesting/Shared/Map/GridRotation_Tests.cs index f90fa326d00..373ac2073f0 100644 --- a/Robust.UnitTesting/Shared/Map/GridRotation_Tests.cs +++ b/Robust.UnitTesting/Shared/Map/GridRotation_Tests.cs @@ -30,7 +30,7 @@ public async Task TestLocalWorldConversions() await server.WaitAssertion(() => { - entMan.System().CreateMap(out var mapId); + mapSystem.CreateMap(out var mapId); var grid = mapMan.CreateGridEntity(mapId); var gridEnt = grid.Owner; var coordinates = new EntityCoordinates(gridEnt, new Vector2(10, 0)); @@ -41,18 +41,18 @@ await server.WaitAssertion(() => Assert.That(mapSystem.WorldToLocal(grid.Owner, grid.Comp, coordinates.Position), Is.EqualTo(coordinates.Position)); // Rotate 180 degrees should show -10, 0 for the position in map-terms and 10, 0 for the position in entity terms (i.e. no change). - entMan.GetComponent(gridEnt).WorldRotation += new Angle(MathF.PI); + transformSystem.SetWorldRotation(gridEnt, transformSystem.GetWorldRotation(gridEnt) + new Angle(MathF.PI)); Assert.That(transformSystem.GetWorldRotation(gridEnt), Is.EqualTo(new Angle(MathF.PI))); // Check the map coordinate rotates correctly - Assert.That(mapSystem.WorldToLocal(grid.Owner, grid.Comp, new Vector2(10, 0)).EqualsApprox(new Vector2(-10, 0), 0.01f)); - Assert.That(mapSystem.LocalToWorld(grid.Owner, grid.Comp, coordinates.Position).EqualsApprox(new Vector2(-10, 0), 0.01f)); + Assert.That(mapSystem.WorldToLocal(gridEnt, grid.Comp, new Vector2(10, 0)).EqualsApprox(new Vector2(-10, 0), 0.01f)); + Assert.That(mapSystem.LocalToWorld(gridEnt, grid.Comp, coordinates.Position).EqualsApprox(new Vector2(-10, 0), 0.01f)); // Now we'll do the same for 180 degrees. - entMan.GetComponent(gridEnt).WorldRotation += MathF.PI / 2f; + transformSystem.SetWorldRotation(gridEnt, transformSystem.GetWorldRotation(gridEnt) + MathF.PI / 2f); // If grid facing down then worldpos of 10, 0 gets rotated 90 degrees CCW and hence should be 0, 10 - Assert.That(mapSystem.WorldToLocal(grid.Owner, grid.Comp, new Vector2(10, 0)).EqualsApprox(new Vector2(0, 10), 0.01f)); + Assert.That(mapSystem.WorldToLocal(gridEnt, grid.Comp, new Vector2(10, 0)).EqualsApprox(new Vector2(0, 10), 0.01f)); // If grid facing down then local 10,0 pos should just return 0, -10 given it's aligned with the rotation. - Assert.That(mapSystem.LocalToWorld(grid.Owner, grid.Comp, coordinates.Position).EqualsApprox(new Vector2(0, -10), 0.01f)); + Assert.That(mapSystem.LocalToWorld(gridEnt, grid.Comp, coordinates.Position).EqualsApprox(new Vector2(0, -10), 0.01f)); }); } @@ -70,7 +70,7 @@ public async Task TestChunkRotations() await server.WaitAssertion(() => { - entMan.System().CreateMap(out var mapId); + mapSystem.CreateMap(out var mapId); var grid = mapMan.CreateGridEntity(mapId); var gridEnt = grid.Owner; @@ -85,7 +85,7 @@ await server.WaitAssertion(() => } } - var chunks = mapSystem.GetMapChunks(grid.Owner, grid.Comp).Select(c => c.Value).ToList(); + var chunks = mapSystem.GetMapChunks(gridEnt, grid.Comp).Select(c => c.Value).ToList(); Assert.That(chunks.Count, Is.EqualTo(1)); var chunk = chunks[0]; diff --git a/Robust.UnitTesting/Shared/Physics/CollisionWake_Test.cs b/Robust.UnitTesting/Shared/Physics/CollisionWake_Test.cs index ed15497a39d..126108f8e00 100644 --- a/Robust.UnitTesting/Shared/Physics/CollisionWake_Test.cs +++ b/Robust.UnitTesting/Shared/Physics/CollisionWake_Test.cs @@ -42,6 +42,8 @@ public async Task TestCollisionWakeGrid() var entManager = server.ResolveDependency(); var mapManager = server.ResolveDependency(); + var mapSystem = entManager.System(); + var transformSystem = entManager.System(); Entity grid = default!; MapId mapId = default!; @@ -51,14 +53,15 @@ public async Task TestCollisionWakeGrid() await server.WaitPost(() => { - entManager.System().CreateMap(out mapId); + mapSystem.CreateMap(out mapId); grid = mapManager.CreateGridEntity(mapId); - grid.Comp.SetTile(Vector2i.Zero, new Tile(1)); + mapSystem.SetTile(grid, Vector2i.Zero, new Tile(1)); var entityOne = entManager.SpawnEntity("CollisionWakeTestItem", new MapCoordinates(Vector2.One * 2f, mapId)); entityOnePhysics = entManager.GetComponent(entityOne); xform = entManager.GetComponent(entityOne); - Assert.That(xform.ParentUid == mapManager.GetMapEntityId(mapId)); + mapSystem.TryGetMap(mapId, out var mapUid); + Assert.That(xform.ParentUid == mapUid); var entityTwo = entManager.SpawnEntity("CollisionWakeTestItem", new EntityCoordinates(grid, new Vector2(0.5f, 0.5f))); entityTwoPhysics = entManager.GetComponent(entityTwo); From 127d8b584885bfc7d9289f4516022738ba50c5e9 Mon Sep 17 00:00:00 2001 From: MilenVolf Date: Tue, 12 Nov 2024 20:58:56 +0300 Subject: [PATCH 2/2] Guh --- Robust.Client/Placement/Modes/AlignTileEmpty.cs | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/Robust.Client/Placement/Modes/AlignTileEmpty.cs b/Robust.Client/Placement/Modes/AlignTileEmpty.cs index 7de18033dda..51d8e2631e6 100644 --- a/Robust.Client/Placement/Modes/AlignTileEmpty.cs +++ b/Robust.Client/Placement/Modes/AlignTileEmpty.cs @@ -23,7 +23,7 @@ public override void AlignPlacementMode(ScreenCoordinates mouseScreen) if (gridIdOpt is { } gridId && gridId.IsValid()) { var mapGrid = pManager.EntityManager.GetComponent(gridId); - CurrentTile = pManager.EntityManager.System().GetTileRef(gridId, mapGrid ,MouseCoords); + CurrentTile = pManager.EntityManager.System().GetTileRef(gridId, mapGrid ,MouseCoords); tileSize = mapGrid.TileSize; //convert from ushort to float }