Skip to content

Commit f2e47ea

Browse files
authored
Merge pull request #578 from sparcs-kaist/577-logging-login-deny-reason
#577 로그인 거부시 거부 사유를 로그에 기록
2 parents 20791ff + 6457b3c commit f2e47ea

File tree

1 file changed

+10
-3
lines changed

1 file changed

+10
-3
lines changed

src/services/auth.js

+10-3
Original file line numberDiff line numberDiff line change
@@ -21,17 +21,18 @@ const transUserData = (userData) => {
2121
const kaistInfo = userData.kaist_info ? JSON.parse(userData.kaist_info) : {};
2222

2323
// info.ku_std_no: 학번
24-
// info.isEligible: 카이스트 구성원인지 여부. DB에 저장하지 않음.
24+
// info.isEligible: 카이스트 구성원인지 여부
2525
const info = {
2626
id: userData.uid,
2727
sid: userData.sid,
2828
name: getFullUsername(userData.first_name, userData.last_name),
2929
facebook: userData.facebook_id || "",
3030
twitter: userData.twitter_id || "",
3131
kaist: kaistInfo?.ku_std_no || "",
32+
kaistType: kaistInfo?.employeeType || "", // DB에 저장하지 않음
3233
sparcs: userData.sparcs_id || "",
3334
email: kaistInfo?.mail || userData.email,
34-
isEligible: userPattern.allowedEmployeeTypes.test(kaistInfo?.employeeType),
35+
isEligible: userPattern.allowedEmployeeTypes.test(kaistInfo?.employeeType), // DB에 저장하지 않음
3536
};
3637
return info;
3738
};
@@ -164,6 +165,8 @@ const sparcsssoCallbackHandler = (req, res) => {
164165
}
165166

166167
if (state !== stateForCmp) {
168+
logger.info("Login denied: state mismatch");
169+
167170
const redirectUrl = new URL("/login/fail", redirectOrigin).href;
168171
return res.redirect(redirectUrl);
169172
}
@@ -175,7 +178,11 @@ const sparcsssoCallbackHandler = (req, res) => {
175178
tryLogin(req, res, userData, redirectOrigin, redirectPath);
176179
} else {
177180
// 카이스트 구성원이 아닌 경우, SSO 로그아웃 이후, 로그인 실패 URI 로 이동합니다
178-
const { sid } = userData;
181+
const { id, sid, kaist, kaistType } = userData;
182+
logger.info(
183+
`Login denied: not a KAIST member (uid: ${id}, sid: ${sid}, kaist: ${kaist}, kaistType: ${kaistType})`
184+
);
185+
179186
const redirectUrl = new URL("/login/fail", redirectOrigin).href;
180187
const ssoLogoutUrl = ssoClient.getLogoutUrl(sid, redirectUrl);
181188
res.redirect(ssoLogoutUrl);

0 commit comments

Comments
 (0)