Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Show "Preview of #" in title #2030

Closed
marcoscaceres opened this issue Jan 14, 2019 · 13 comments · Fixed by #2251
Closed

Show "Preview of #" in title #2030

marcoscaceres opened this issue Jan 14, 2019 · 13 comments · Fixed by #2251
Labels
enhancement good first issue These bug should be easy for anyone getting started

Comments

@marcoscaceres
Copy link
Contributor

marcoscaceres commented Jan 14, 2019

See the following for details:
tobie/pr-preview#23

Basically, the spec's title should come "Preview of PR xxx: " when the spec isPreview is true.

This would build on @yatri1609's work:
https://github.com/w3c/respec/pull/1843

@marcoscaceres marcoscaceres changed the title Show "Preview of #" is title Show "Preview of #" in title Jan 14, 2019
@marcoscaceres marcoscaceres added good first issue These bug should be easy for anyone getting started enhancement labels Jan 14, 2019
@marcoscaceres
Copy link
Contributor Author

@yatri1609, you want to take this one too? It's just a repeat of what you did previously - but this one changes the <h1> and <title> of the document.

@yatri1609
Copy link
Contributor

@marcoscaceres I'll take this one up !! 😀

@marcoscaceres
Copy link
Contributor Author

@yatri1609, much appreciated! Let me know if you need any more details or additional guidance.

@shreya99oak
Copy link

@yatri1609 are you still working on it? @marcoscaceres can I work on it?

@yatri1609
Copy link
Contributor

@shreya99oak yes I'm working on it you can have a look at other issues

@marcoscaceres
Copy link
Contributor Author

@shreya99oak there are a few easy tasks in this issue:
https://github.com/w3c/respec/issues/1582

@shreya99oak
Copy link

@shreya99oak there are a few easy tasks in this issue:
#1582
Ohk I'll have a look at it!

@marcoscaceres
Copy link
Contributor Author

@shreya99oak, this one just came up:
https://github.com/w3c/respec/issues/2051

It's a relatively easy one, but super useful/important. Do you think you could take it on?

@yatri1609
Copy link
Contributor

@marcoscaceres The title must be "Preview of PR xxx: " instead of "This is a preview of pull request PR number. Am I understanding it correct?

@marcoscaceres
Copy link
Contributor Author

Yes, that’s correct.

@yatri1609
Copy link
Contributor

@marcoscaceres great I'll do that !

@ThobyV
Copy link
Contributor

ThobyV commented Apr 3, 2019

Is there a person working on this issue please?

@marcoscaceres
Copy link
Contributor Author

It’s all yours @ThobyV

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement good first issue These bug should be easy for anyone getting started
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants