From 98fb654feb0bc4f34bed97d7600858ae863a7b60 Mon Sep 17 00:00:00 2001 From: Tiffany Sonny Date: Wed, 13 Jul 2022 10:35:11 -0700 Subject: [PATCH 1/2] Added escape for special characters in link. Also modified link text capture to start with "Wait... --- .../setup/install/providers/kubernetes-v2/k8s-provider.md | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/content/en/docs/setup/install/providers/kubernetes-v2/k8s-provider.md b/content/en/docs/setup/install/providers/kubernetes-v2/k8s-provider.md index 93357990..96e3550e 100644 --- a/content/en/docs/setup/install/providers/kubernetes-v2/k8s-provider.md +++ b/content/en/docs/setup/install/providers/kubernetes-v2/k8s-provider.md @@ -6,7 +6,7 @@ description: > --- Spinnaker's Kubernetes provider fully supports Kubernetes-native, manifest-based deployments and is the recommended provider for deploying to Kubernetes with Spinnaker. -[Spinnaker's legacy Kubernetes provider](https://www.spinnaker.io/setup/install/providers/kubernetes/) +[Spinnaker\'s legacy Kubernetes provider](https://www.spinnaker.io/setup/install/providers/kubernetes/) is [scheduled for removal](https://github.com/spinnaker/governance/blob/master/rfc/eol_kubernetes_v1.md) in Spinnaker 1.21. ## Accounts @@ -96,7 +96,7 @@ you must specify that namespace when you add the account to Spinnaker. If you don't specify any namespaces, then Spinnaker will attempt to list all namespaces, which requires a cluster-wide role. Without a cluster-wide role configured and specified namespaces, you will see deployment -[timeouts in the "Wait for Manifest to Stabilize" task](https://github.com/spinnaker/spinnaker/issues/3666#issuecomment-485001361). +timeouts in the [\"Wait for Manifest to Stabilize\" task](https://github.com/spinnaker/spinnaker/issues/3666#issuecomment-485001361). ```yaml apiVersion: rbac.authorization.k8s.io/v1 From e7e9e9e4882b80dba41868ff74b362a407a8ed77 Mon Sep 17 00:00:00 2001 From: Tiffany Sonny Date: Mon, 17 Oct 2022 12:26:03 -0700 Subject: [PATCH 2/2] fix(docs): link to creating a service account --- .../setup/install/providers/kubernetes-v2/_index.md | 10 +++++++--- 1 file changed, 7 insertions(+), 3 deletions(-) diff --git a/content/en/docs/setup/install/providers/kubernetes-v2/_index.md b/content/en/docs/setup/install/providers/kubernetes-v2/_index.md index 943f2d79..f09c773f 100644 --- a/content/en/docs/setup/install/providers/kubernetes-v2/_index.md +++ b/content/en/docs/setup/install/providers/kubernetes-v2/_index.md @@ -39,16 +39,20 @@ The Kubernetes provider has two requirements: ### Optional: Create a Kubernetes Service Account -If you want, you can associate Spinnaker with a [Kubernetes Service +You can associate Spinnaker with a [Kubernetes Service Account](https://kubernetes.io/docs/reference/access-authn-authz/service-accounts-admin/), even when managing multiple Kubernetes clusters. This can be useful if you need to grant Spinnaker certain roles in the cluster later on, or you typically depend on an authentication mechanism that doesn't work in all environments. -Given that you want to create a Service Account in existing context `$CONTEXT`, -the following commands will create `spinnaker-service-account`, and add its +The following example assumes you want to create a Service Account in an existing context `$CONTEXT`. +In this example, the commands create the `spinnaker-service-account`, and add its token under a new user called `${CONTEXT}-token-user` in context `$CONTEXT`. +{{% alert color="info" title="Tip" %}}For more information about creating a Service Account, see [Creating service accounts](https://spinnaker.io/docs/setup/other_config/security/authorization/service-accounts/#creating-service-accounts).{{% /alert %}} + +```bash + ```bash CONTEXT=$(kubectl config current-context)