Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unable to use spring.fu.jafu with jigsaw modules, due unnamed module. #357

Open
extenda-vladlen-gladis opened this issue Dec 17, 2020 · 2 comments
Labels
type: enhancement A general enhancement

Comments

@extenda-vladlen-gladis
Copy link

extenda-vladlen-gladis commented Dec 17, 2020

Hi there, could you transform published spring.fu.jafu artifact from unnamed module to the automatic one, by adding the following line to MANIFEST.MF
Automatic-Module-Name: spring.fu.jafu

@sdeleuze sdeleuze added the status: waiting-for-triage An issue we've not yet triaged or decided on label Jan 8, 2021
@sdeleuze
Copy link
Collaborator

sdeleuze commented Apr 7, 2021

Hi, we could add this entry, but I am not sure we can support modules yet due to the split packages issue. Could you check locally and provide us your feedback about if that works or not?

@gvart-sellics
Copy link

@sdeleuze it worked fine with hardcoded value inside jar file

@sdeleuze sdeleuze added this to the 0.4.5 milestone Jul 27, 2021
@sdeleuze sdeleuze added type: enhancement A general enhancement and removed status: waiting-for-triage An issue we've not yet triaged or decided on labels Jul 27, 2021
@sdeleuze sdeleuze modified the milestones: 0.5.0, 0.5.1 Dec 28, 2021
@sdeleuze sdeleuze modified the milestones: 0.5.1, General backlog Mar 31, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type: enhancement A general enhancement
Projects
None yet
Development

No branches or pull requests

3 participants